Skip to content

Guard the broadcast weight update with a store ticket lock to remove Ray based locks - #2144

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op12-1from
tom/refactor-miles/op12-2
Open

Guard the broadcast weight update with a store ticket lock to remove Ray based locks#2144
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op12-1from
tom/refactor-miles/op12-2

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from b2fbeba to 8b2f13b Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 3558c4e to 9697adf Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 8b2f13b to 5d566df Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 9697adf to 9ffac37 Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy requested a review from jybsuper as a code owner August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 5d566df to b3f2ed7 Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 9ffac37 to 9116b42 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from b3f2ed7 to 0dc141a Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 9116b42 to f657fc7 Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch 3 times, most recently from 7462c9e to 8baff73 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 5efda26 to 7dcf53b Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 8baff73 to ec49ebe Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 820cf2c to a960834 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from ec49ebe to 7f8aa88 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from a960834 to bfad33c Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 7f8aa88 to 3f5f3db Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from bfad33c to 8b66f2c Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 3f5f3db to 7266995 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 8b66f2c to e43aa5c Compare August 13, 2026 06:39

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the #1837 stack context. The failure-recovery concern is covered by the cell teardown path in #2154 and hardened in #2173; both land before the #2176 safe-merge checkpoint and remain intact through tip #2649. No blocking issues remain.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-1 branch from 9c04d57 to 4618ca5 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op12-2 branch from 1bf6fb4 to 38f1c95 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants