Skip to content

Add acquires_lock and releases_lock for split lock windows - #2104

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-103from
tom/refactor-miles/op13-104
Open

Add acquires_lock and releases_lock for split lock windows#2104
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-103from
tom/refactor-miles/op13-104

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 4fc7003 to 97c3c0a Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 2 times, most recently from 7a70205 to d2eb99a Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from d01dcc1 to d545d02 Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from d2eb99a to 402aad1 Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from d545d02 to 4c7e67e Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from 402aad1 to 37462a1 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 4c7e67e to 0a41dd6 Compare August 4, 2026 07:23
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from 37462a1 to 546ecc7 Compare August 4, 2026 07:23
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 0a41dd6 to 569528a Compare August 4, 2026 07:30
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from 546ecc7 to 7ce2b5b Compare August 4, 2026 07:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 569528a to ad9b000 Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 2 times, most recently from 60d4450 to febcc22 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from ad9b000 to 98c21e4 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from febcc22 to b74a0f6 Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 1ac1aca to ec6eed7 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from b74a0f6 to b8b0c18 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from ec6eed7 to 8a5722e Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 2 times, most recently from 625f9aa to ee8fe50 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 4603b21 to 924939b Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from ee8fe50 to 4e8269b Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 924939b to f55567f Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from 4e8269b to eb82f68 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from f55567f to 87a0f20 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 2 times, most recently from 0094c14 to f8d66e9 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from bbb0316 to fe3978c Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 2 times, most recently from e7e2e8e to ccb6823 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 3e866ef to 7311b99 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from ccb6823 to 0754207 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 7311b99 to 32d177b Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from 0754207 to 228b72a Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 32d177b to e57e2ce Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch 3 times, most recently from 8183120 to c02c940 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 8a12bc4 to f9f4340 Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-104 branch from c02c940 to 752d4fa Compare August 14, 2026 04:46

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in stack context only. [P2] #2104's identity-only grant could let a stale child task bypass serialization or release a later owner's lock; #2306 replaces it with generation-scoped grants before checkpoint #2176, and the fix remains through checked tip #2649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants