Skip to content

Add a requires_lock decorator to ensure lock is being held - #2103

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-102from
tom/refactor-miles/op13-103
Open

Add a requires_lock decorator to ensure lock is being held#2103
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-102from
tom/refactor-miles/op13-103

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 1be1caa to ae6c494 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 3 times, most recently from d01dcc1 to d545d02 Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 11fac3e to dd78cfd Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from d545d02 to 4c7e67e Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from dd78cfd to fbf37c3 Compare August 4, 2026 07:23
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 4c7e67e to 0a41dd6 Compare August 4, 2026 07:23
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from fbf37c3 to 2f067af Compare August 4, 2026 07:30
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 0a41dd6 to 569528a Compare August 4, 2026 07:30
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 2f067af to fc230e5 Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from ad9b000 to 98c21e4 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 22efc11 to 5d83947 Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from 1ac1aca to ec6eed7 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 9c3ff01 to da4df26 Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from ec6eed7 to 8a5722e Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from da4df26 to 947ba45 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 8a5722e to 4603b21 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 4603b21 to 924939b Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 947ba45 to 6520292 Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 924939b to f55567f Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 533ea6e to df8ef9c Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from 87a0f20 to bbb0316 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from df8ef9c to aa82613 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from bbb0316 to fe3978c Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch 2 times, most recently from d4fe48d to 49659fc Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from fe3978c to 3e866ef Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 49659fc to 9e466b2 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from 3e866ef to 7311b99 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 9e466b2 to 7205645 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from 32d177b to e57e2ce Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 8cc072e to 9ebb5bc Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from e57e2ce to 14821e1 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-102 branch from 9ebb5bc to c2b4139 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch 2 times, most recently from 8a12bc4 to f9f4340 Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack-context LGTM. The [P2] inherited ContextVar grant in #2103 can let an outliving child enter guarded code after release, but #2306 fixes this before production integration and safe merge checkpoint #2176; the repair remains through checked tip #2649.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-103 branch from f9f4340 to 824b417 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants