Add a periodic tick sweep over the rollout cells - #2097
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 3, 2026 15:01
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 3, 2026 23:43
9a663a9 to
f3701c7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
2 times, most recently
from
August 4, 2026 00:38
dde9aec to
a7b458d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 4, 2026 02:36
0cfae7d to
2a9824b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 4, 2026 02:36
a7b458d to
137f21d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 4, 2026 06:53
2a9824b to
13811cb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 4, 2026 06:53
137f21d to
58a69cf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 4, 2026 07:24
13811cb to
2589578
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 4, 2026 07:24
58a69cf to
47c83b9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 4, 2026 07:31
2589578 to
206df79
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
2 times, most recently
from
August 6, 2026 03:46
9abc46a to
d0fbbff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 6, 2026 03:46
206df79 to
bfc30f2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 6, 2026 07:04
d0fbbff to
d58254d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 6, 2026 07:04
bfc30f2 to
e024b0e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
2 times, most recently
from
August 10, 2026 00:44
a3ac4fb to
d825a69
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 10, 2026 06:00
9d64207 to
37be5f8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 10, 2026 06:00
d825a69 to
29be034
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 10, 2026 16:06
37be5f8 to
5877b7a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
4 times, most recently
from
August 12, 2026 09:32
88ea78b to
ca37002
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 12, 2026 14:31
97b950a to
cdc6b8b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
2 times, most recently
from
August 12, 2026 14:36
6f8ab9a to
262ab1d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
2 times, most recently
from
August 12, 2026 23:56
0bf7952 to
de3bffa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
3 times, most recently
from
August 13, 2026 03:11
e5c5f0c to
3d17ff6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 13, 2026 03:25
1122d4e to
e37180c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 13, 2026 03:25
3d17ff6 to
4cd949d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 13, 2026 06:00
e37180c to
8ff168d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 13, 2026 06:00
4cd949d to
8eee1c8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 13, 2026 06:39
8ff168d to
b2fa901
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 13, 2026 06:39
8eee1c8 to
72adb4a
Compare
The cell state machine is about to grow steps that must run outside the reconcile path. Add the driver for them: an empty per-cell tick plus the controller loop that sweeps every cell, survives a failing cell and is cancelled on teardown.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-118
branch
from
August 14, 2026 04:45
b2fa901 to
fd2f4ec
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-119
branch
from
August 14, 2026 04:45
72adb4a to
cdfe05f
Compare
guapisolo
reviewed
Aug 27, 2026
| self._task.cancel() | ||
| try: | ||
| await self._task | ||
| except asyncio.CancelledError: |
Collaborator
There was a problem hiding this comment.
[P2] Preserve cancellation from the disposing caller
SimpleTicker.dispose() catches every asyncio.CancelledError raised at this await, so it cannot distinguish the expected cancellation of self._task from cancellation of the task currently disposing the controller. If an outer shutdown deadline fires while this await is pending, that cancellation is swallowed and InferenceController.dispose() continues into watcher teardown instead of propagating it. This remains unchanged at safe-merge checkpoint #2176 and checked tip #2649. Please consume only the owned ticker task cancellation and add a deterministic test that cancels the dispose caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837