Skip to content

Restructure the rollout cell states while keeping the current behavior - #2088

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-90from
tom/refactor-miles/op13-89
Open

Restructure the rollout cell states while keeping the current behavior#2088
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-90from
tom/refactor-miles/op13-89

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 101caed to 55c28ef Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch 2 times, most recently from 4fec0bc to c002fc1 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 55c28ef to 01fe171 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from c002fc1 to f8a3663 Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 2 times, most recently from 4f87107 to 8d08288 Compare August 4, 2026 06:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from f8a3663 to f24eade Compare August 4, 2026 06:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 8d08288 to 4083bfb Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from f24eade to 496f08b Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 4083bfb to dfa8690 Compare August 4, 2026 07:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 496f08b to f62c9de Compare August 4, 2026 07:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from dfa8690 to 8786d4d Compare August 6, 2026 03:49
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch 2 times, most recently from 2c11dac to b9218cf Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 2 times, most recently from 04964cd to 7ac4e01 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 38d4218 to 7f28d20 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 2 times, most recently from 6265a01 to bb86134 Compare August 10, 2026 06:05
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 7f28d20 to e60804a Compare August 10, 2026 06:05
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from bb86134 to b297b6c Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch 2 times, most recently from a60d7b3 to e812dde Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 3 times, most recently from 57ce1ed to ad9afb6 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 26cc35b to 56bb2bb Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 2 times, most recently from 3a38cc4 to 973c34c Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 56bb2bb to 5f25a96 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 973c34c to bcddb63 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 6860489 to 0c81d18 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from bcddb63 to 07d917a Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 0c81d18 to f9dc73a Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 07d917a to 95bf7f3 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from f9dc73a to 9ccf6d4 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch 2 times, most recently from 8b757a8 to 77524fb Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 9ccf6d4 to 52b244d Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from 77524fb to e4eed7a Compare August 13, 2026 06:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from 69df01e to f6e9aa5 Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from e4eed7a to ce4e1d5 Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in stack context: the [P1] rollout-startup failure introduced in #2088 when check_weight_update_equal is enabled is fixed by #2098 before safe checkpoint #2176, and the fix remains present through the checked tip #2649.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-89 branch from ce4e1d5 to 7be0c73 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-90 branch from f6e9aa5 to 6959b97 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants