Rename the remaining cell start and stop wording to add and dispose - #2070
Open
fzyzcjy wants to merge 1 commit into
Open
Rename the remaining cell start and stop wording to add and dispose#2070fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 2, 2026 09:07
38dd2cf to
611ed8c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 2, 2026 09:44
f844581 to
cc6b604
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 2, 2026 10:02
a39737b to
8fc2cf2
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 2, 2026 10:02
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 2, 2026 10:02
cc6b604 to
0f1c856
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 2, 2026 12:41
8fc2cf2 to
e7ed9be
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 2, 2026 12:41
0f1c856 to
660c384
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 3, 2026 23:44
e7ed9be to
98a97cf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 3, 2026 23:44
660c384 to
5906737
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 00:39
98a97cf to
cae3d4a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 4, 2026 00:39
5906737 to
06e2e40
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 06:55
cae3d4a to
66ccbf1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 4, 2026 06:56
06e2e40 to
4a3d5de
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 07:28
66ccbf1 to
ef9c0b7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 4, 2026 07:28
4a3d5de to
5b9d878
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 4, 2026 07:35
ef9c0b7 to
02d4114
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 6, 2026 03:49
8837ee5 to
d01720a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 10, 2026 00:44
56c5dc7 to
a0c161a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 06:05
fd181c3 to
9609dcc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 10, 2026 06:05
a0c161a to
fce01bf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 16:07
9609dcc to
765db35
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 10, 2026 16:07
fce01bf to
4b6cde8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 10, 2026 16:34
765db35 to
2c3853e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 12, 2026 02:48
108a6ea to
ea170ae
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 12, 2026 02:48
2c3853e to
ea06df8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 12, 2026 14:31
942463f to
6d46602
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 12, 2026 14:36
2a107f6 to
d568b31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 12, 2026 14:36
6d46602 to
8d8f7bf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 12, 2026 23:56
d568b31 to
974c52d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 13, 2026 01:13
924544f to
ba5495b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 13, 2026 01:13
974c52d to
b6cd643
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
2 times, most recently
from
August 13, 2026 03:25
f72ff93 to
c983893
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
2 times, most recently
from
August 13, 2026 06:00
bd8a5be to
dae9e8a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 13, 2026 06:01
c983893 to
a75abb7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 13, 2026 06:39
dae9e8a to
ea9eded
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 13, 2026 06:39
a75abb7 to
82bd6f0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 14, 2026 04:45
ea9eded to
f34b9a1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 14, 2026 04:46
82bd6f0 to
49c0176
Compare
guapisolo
approved these changes
Aug 27, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Codex stack review: #2070 preserves behavior while aligning lifecycle names with ownership—RayWorkerManager owns worker processes, while RolloutServer and ServerCell manage logical membership and router registration. No #2070 follow-up is needed before safe-merge checkpoint #2176; checked tip is #2649.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-82
branch
from
August 29, 2026 12:38
f34b9a1 to
a610b52
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-84
branch
from
August 29, 2026 12:38
49c0176 to
6b4155b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837