Skip to content

Extract the immutable ServerCell metadata to avoid constructing ServerCell later - #2066

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-79from
tom/refactor-miles/op13-83
Open

Extract the immutable ServerCell metadata to avoid constructing ServerCell later#2066
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-79from
tom/refactor-miles/op13-83

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 2e25e3b to bb65f77 Compare August 2, 2026 09:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch 2 times, most recently from f1ce6e1 to 49f5c02 Compare August 2, 2026 09:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from bb65f77 to 577be07 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 49f5c02 to c048486 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 577be07 to b18d2bb Compare August 2, 2026 12:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from c048486 to b35450c Compare August 2, 2026 12:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from b18d2bb to 8905ed1 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from b35450c to 0bb4169 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 8905ed1 to 51ad90c Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 0bb4169 to 4be17c4 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 51ad90c to dc8b527 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 4be17c4 to 5a420fa Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from dc8b527 to 85ac761 Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 5a420fa to 87af06a Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 85ac761 to 084d62c Compare August 4, 2026 07:35
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 87af06a to d8f3b86 Compare August 4, 2026 07:35
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 084d62c to 3d82cf1 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch 2 times, most recently from 1a4057d to fa49c03 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 649cc40 to 9874483 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch 2 times, most recently from 5dc768d to b94e978 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 56a4461 to 54ab310 Compare August 10, 2026 06:05
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch 6 times, most recently from b64d35b to e3df89c Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from d2799fd to 8a19dee Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from e3df89c to 3e2b992 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 8a19dee to c6f6a19 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch 2 times, most recently from 6530e2a to d06e89a Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 79f2f7b to 5b7b819 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from d06e89a to 43c6682 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 5b7b819 to d297915 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 43c6682 to 938669a Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from d297915 to 9b6dc7a Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 938669a to bd17131 Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 9b6dc7a to a68d6f0 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from bd17131 to 6a0dae9 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from a68d6f0 to f39082b Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 6a0dae9 to 558c923 Compare August 14, 2026 04:46

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #2066 changes in the #1837 stack through checked tip #2649. #2066 fixes the ServerCell metadata/lifecycle-state coupling, with no blocking issue found before safe merge checkpoint #2176.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from f39082b to 1752c9b Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-83 branch from 558c923 to 0135a7b Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants