Skip to content

Remove the unnecessary debug_train_only guard when starting cells - #2065

Merged
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-79
Sep 4, 2026
Merged

fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-79

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 6da4d82 to 62ecce6 Compare August 2, 2026 09:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 2e25e3b to bb65f77 Compare August 2, 2026 09:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 62ecce6 to 6f0ac23 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from bb65f77 to 577be07 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 6f0ac23 to 9a86879 Compare August 2, 2026 12:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from b18d2bb to 8905ed1 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 9a86879 to 7057cbc Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 8905ed1 to 51ad90c Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch 2 times, most recently from 44c5b7a to a71821a Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy requested a review from Rockdu as a August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 51ad90c to dc8b527 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from a71821a to f4fdf8d Compare August 4, 2026 07:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from dc8b527 to 85ac761 Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from f4fdf8d to 13a6f4d Compare August 4, 2026 07:35
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 85ac761 to 084d62c Compare August 4, 2026 07:35
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 13a6f4d to de6edc2 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 084d62c to 3d82cf1 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from de6edc2 to aa19574 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from 3d82cf1 to 649cc40 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from c1abe65 to 6d24f96 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from 8a19dee to c6f6a19 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 0fad5dd to d70f47b Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from c6f6a19 to 79f2f7b Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from d70f47b to d0ad057 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from 5b7b819 to d297915 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 0df85c8 to bedf864 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from d297915 to 9b6dc7a Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from bedf864 to fcc185f Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from a68d6f0 to f39082b Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug_train_only lifecycle gate remains at InferenceController.init(), so PR #2065 safely removes the duplicate RolloutServer guard. Verified at safe merge checkpoint #2176 and through checked tip #2649; LGTM.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 7aedf4f to 7b700db Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 3 times, most recently from ace9fdd to d429e3c Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 077489c to dde1057 Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from 155ea38 to d65dc44 Compare September 1, 2026 14:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch 2 times, most recently from 56565c7 to b25abd8 Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from d65dc44 to 63f8d5f Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from b25abd8 to ff82395 Compare September 3, 2026 06:20
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch 2 times, most recently from b1a7732 to ba8871d Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-78 branch from 912e09c to 950a9d6 Compare September 3, 2026 07:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-79 branch from ba8871d to 50ebdff Compare September 3, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants