Skip to content

Remove server liveness check in health waiting - #2062

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-72from
tom/refactor-miles/op13-75
Open

Remove server liveness check in health waiting#2062
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-72from
tom/refactor-miles/op13-75

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 2b304c8 to 7fe9b44 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from bbd3927 to ad33935 Compare August 2, 2026 10:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 7fe9b44 to 89b87e1 Compare August 2, 2026 12:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from ad33935 to 074a0f4 Compare August 2, 2026 12:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 89b87e1 to 8fa52b8 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 074a0f4 to 7c27207 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 8fa52b8 to f2ab9f8 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 7c27207 to 94946bc Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from f2ab9f8 to 638eb61 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 94946bc to f8fc083 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 638eb61 to 6761845 Compare August 4, 2026 07:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from f8fc083 to 45301aa Compare August 4, 2026 07:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 6761845 to a609eb8 Compare August 4, 2026 07:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 45301aa to 63ae2a5 Compare August 4, 2026 07:35
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from a609eb8 to d4dedaa Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 63ae2a5 to bf132fc Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from d4dedaa to 20b85e4 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from bf132fc to 0f9be6e Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 20b85e4 to f4e8551 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 0f9be6e to e483c8f Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from f4e8551 to b50d123 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from e483c8f to 35d3292 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from b50d123 to 14ef373 Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch 2 times, most recently from d19c15c to 28cee4e Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 14ef373 to 0a8ed16 Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch 3 times, most recently from bf210f6 to d68c2a7 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 4b70217 to 85f188f Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from d68c2a7 to 5071260 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 85f188f to 4e63224 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch 3 times, most recently from dbd70a1 to b7efa41 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch 2 times, most recently from b04027d to 6eab71e Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch 3 times, most recently from f656dc3 to f2e5f9e Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 03e6a02 to 8a526bd Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch 2 times, most recently from 413be81 to 682a436 Compare August 14, 2026 04:46
@guapisolo

Copy link
Copy Markdown
Collaborator

[P1] In isolation, #2062 can block rollout initialization indefinitely when SGLang exits before readiness; #2098 replaces the production waiter with bounded, tick-driven probes before #2176, and the fix remains present through #2649, so no post-checkpoint follow-up is required.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-75 branch from 682a436 to ae052ac Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-72 branch from 089bd14 to 8aa0745 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants