Support master-mode ports in RayWorkerManager - #2055
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 2, 2026 08:56
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 2, 2026 12:40
10aff41 to
dbe7f6b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
2 times, most recently
from
August 3, 2026 23:44
3f936f3 to
d852042
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 4, 2026 00:39
892af8c to
cd92abc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 4, 2026 00:39
d852042 to
56967dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 4, 2026 06:55
cd92abc to
57d8525
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 4, 2026 06:55
56967dc to
2500689
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 4, 2026 07:26
57d8525 to
420b243
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 4, 2026 07:27
2500689 to
2a0c283
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 4, 2026 07:34
420b243 to
1238e42
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
2 times, most recently
from
August 6, 2026 03:48
d4bb43e to
c9e479d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
2 times, most recently
from
August 6, 2026 07:04
720277a to
639cd30
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 6, 2026 07:04
c9e479d to
4ffcc36
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 9, 2026 23:32
639cd30 to
7d48001
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 9, 2026 23:32
4ffcc36 to
4147ba7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 10, 2026 00:44
7d48001 to
a92b5e9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 10, 2026 00:44
4147ba7 to
98e1f2b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-62
branch
from
August 10, 2026 06:04
a92b5e9 to
3a80332
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
2 times, most recently
from
August 10, 2026 16:06
660b7f4 to
f78620f
Compare
fzyzcjy
changed the base branch from
tom/refactor-miles/op13-62
to
tom/refactor-miles/op13-162
August 10, 2026 16:12
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
3 times, most recently
from
August 12, 2026 09:32
ea3d558 to
33048d0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
2 times, most recently
from
August 12, 2026 14:31
1c3c5b8 to
bfc3dd0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 12, 2026 14:31
33048d0 to
d07db3a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 12, 2026 14:36
bfc3dd0 to
c6f4ecf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 12, 2026 14:36
d07db3a to
c8db785
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 12, 2026 23:56
c6f4ecf to
744530d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 12, 2026 23:56
c8db785 to
301974a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 13, 2026 01:13
744530d to
7305fb1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
2 times, most recently
from
August 13, 2026 03:11
012f2d0 to
99fb348
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 13, 2026 03:25
1b9723d to
b37c6ae
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 13, 2026 03:25
99fb348 to
9e5b36d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 13, 2026 06:00
b37c6ae to
8575c09
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 13, 2026 06:00
9e5b36d to
bb92959
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-162
branch
from
August 13, 2026 06:39
8575c09 to
289f562
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 13, 2026 06:39
bb92959 to
8e0ee6d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-63
branch
from
August 14, 2026 04:45
8e0ee6d to
de7038c
Compare
guapisolo
approved these changes
Aug 26, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
[P1][fixed before checkpoint] In #2055, the stale self.cell_index access would crash configured static Session Server ports during worker-manager initialization; #2156 fixes it and #2175 adds the multi-cell regression test before safe merge checkpoint #2176. I verified both remain intact through #2649; LGTM in stack context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837