Skip to content

Use SGLANG_DG_CACHE_DIR_PER_PROCESS instead of hand-built cache dirs - #2000

Merged
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-45
Sep 4, 2026
Merged

fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-45

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from babb28b to 5069f98 Compare August 2, 2026 12:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 3 times, most recently from c66426c to edfe4c0 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from 848d76e to 4c34c76 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy requested a review from Rockdu as a August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch from edfe4c0 to d7de611 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from 4c34c76 to fb9faa3 Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch from d7de611 to 23cb4a9 Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from fb9faa3 to e56df6a Compare August 4, 2026 07:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 2 times, most recently from 145c3c0 to ff743c4 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from e56df6a to fcb858c Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 3 times, most recently from cdf2ac0 to 85ecebd Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch 2 times, most recently from 69d568c to 4b48b33 Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 2 times, most recently from 2dd6411 to 661a870 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from 4b48b33 to 5373370 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch from cdced69 to 2ab4179 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from a2295c8 to deeb9ce Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 3 times, most recently from f323719 to b6e1038 Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in stack context through safe-merge checkpoint #2176 and checked tip #2649. The SGLang-owned per-process DeepGEMM cache isolation is correctly wired; no actionable findings.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 3 times, most recently from af2d8fb to f50e8e5 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch 2 times, most recently from e7705b8 to d03e02d Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 4 times, most recently from 950471d to 7257481 Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from 2c09286 to a7f6b60 Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch from 7257481 to 54a00c9 Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from a7f6b60 to 79fbcef Compare September 3, 2026 07:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 2 times, most recently from 66ef210 to bceb1d9 Compare September 3, 2026 10:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch 2 times, most recently from b65e8cb to 54e881c Compare September 3, 2026 23:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch 2 times, most recently from 0778896 to 8d0e549 Compare September 4, 2026 00:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch 2 times, most recently from 8316a6e to a2c1f77 Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-45 branch from 8d0e549 to 287ad2e Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-40 branch from a2c1f77 to 154c448 Compare September 4, 2026 05:45
Base automatically changed from tom/refactor-miles/op13-40 to main September 4, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants