Repository navigation
Implement a worker spec for the session server - #1999
Merged
Merged
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 30, 2026 14:52
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 2, 2026 12:39
573f4b6 to
9649d29
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 2, 2026 12:39
babb28b to
5069f98
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 3, 2026 23:44
9649d29 to
64bb779
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
2 times, most recently
from
August 4, 2026 00:39
053e3ec to
848d76e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 4, 2026 00:39
64bb779 to
7a0bc27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 4, 2026 06:54
848d76e to
4c34c76
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 4, 2026 06:54
7a0bc27 to
39246a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 4, 2026 07:25
4c34c76 to
fb9faa3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 4, 2026 07:25
39246a2 to
8472d44
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 4, 2026 07:33
fb9faa3 to
e56df6a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 4, 2026 07:33
8472d44 to
3a7d7cb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 6, 2026 03:48
e56df6a to
fcb858c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
2 times, most recently
from
August 6, 2026 07:03
8348150 to
7a4f73d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 6, 2026 07:03
fcb858c to
69db80f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 9, 2026 23:32
7a4f73d to
9d041fe
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 9, 2026 23:32
69db80f to
243c929
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 10, 2026 00:44
9d041fe to
73918fc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 10, 2026 00:44
243c929 to
69d568c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
3 times, most recently
from
August 13, 2026 06:00
a2295c8 to
deeb9ce
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 13, 2026 06:39
040a91f to
bdff66d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
2 times, most recently
from
August 14, 2026 04:46
7d14022 to
343a689
Compare
guapisolo
reviewed
Aug 26, 2026
| class LaunchCommandContext(FrozenStrictBaseModel): | ||
| cell_index: int | ||
| self_addrs: NamedHostAndPorts | ||
| spec_addrs: dict[str, list[NamedHostAndPorts]] |
Collaborator
There was a problem hiding this comment.
Could we rename this to pool_addrs or pool_id_to_addrs and update its callers? This map is keyed by pool IDs (for example, compute_router_pool_id(0)), so spec_addrs treats a spec as an identity and conflicts with .claude/rules/pool-cell-worker-names.md. I checked the stack through safe-merge checkpoint #2176 and the checked #2649 tip; no later PR repairs this naming.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 29, 2026 12:38
2132c95 to
9958b96
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
August 29, 2026 12:38
343a689 to
143718c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
August 31, 2026 23:34
9958b96 to
9813b42
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
3 times, most recently
from
September 1, 2026 10:36
e7705b8 to
d03e02d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 1, 2026 14:33
32524f6 to
566867e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
September 1, 2026 14:33
d03e02d to
3cebd89
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 3, 2026 06:02
566867e to
bdfc510
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
September 3, 2026 06:02
3cebd89 to
37c0df3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 3, 2026 06:20
bdfc510 to
d8fe8da
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
2 times, most recently
from
September 3, 2026 06:33
2c09286 to
a7f6b60
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 3, 2026 07:53
8d1f310 to
b992c6e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
September 3, 2026 07:53
a7f6b60 to
79fbcef
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 3, 2026 10:52
b992c6e to
fcb4ff7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
September 3, 2026 10:52
79fbcef to
b65e8cb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 3, 2026 23:27
fcb4ff7 to
667c824
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
from
September 3, 2026 23:27
b65e8cb to
54e881c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-44
branch
from
September 4, 2026 00:53
667c824 to
b2455dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-40
branch
2 times, most recently
from
September 4, 2026 03:28
8316a6e to
a2c1f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837