Skip to content

Move sglang config resolution into sglang_config.py - #1990

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-38from
tom/refactor-miles/op13-52
Open

Move sglang config resolution into sglang_config.py#1990
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-38from
tom/refactor-miles/op13-52

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from c7d4ab0 to 184ac95 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from 1bdd045 to a9ab4f7 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from 184ac95 to 8d0f0fb Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from a9ab4f7 to 91b8643 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from 8d0f0fb to fa2d97c Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from 91b8643 to 545bcf0 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from fa2d97c to fd94a24 Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from 545bcf0 to cfd2f0e Compare August 4, 2026 07:26
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from fd94a24 to b401083 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from cfd2f0e to d814d0f Compare August 4, 2026 07:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from b401083 to 10c2ec3 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 3 times, most recently from bdbddc7 to bfb0a82 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from 0b58107 to e4856ed Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from bfb0a82 to 2e7de6e Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from e4856ed to 9c5b314 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 2 times, most recently from 3e83605 to 4606f6c Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from 9c5b314 to 4726be4 Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from 4726be4 to fbea9f9 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 2 times, most recently from b406728 to ca19a39 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from b060c70 to f337743 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 2 times, most recently from 47a6848 to c922e33 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch 2 times, most recently from e063711 to b4427a3 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from c922e33 to 9f43231 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from b4427a3 to fa48f6b Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 4 times, most recently from ed1c8f5 to f0651f5 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from cc1c884 to 87195a9 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch 2 times, most recently from 9749217 to c7bf0f4 Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in stack context: the stale _resolve_sglang_config test calls introduced here are fixed by #2108 before safe-merge checkpoint #2176, and the fix remains intact through checked tip #2649. LGTM.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-52 branch from c7bf0f4 to 3f07c93 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-38 branch from a6f8e91 to 02e73c2 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants