Skip to content

Forbid positional arguments when constructing ray actors - #1986

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-29from
tom/refactor-miles/op13-32
Open

Forbid positional arguments when constructing ray actors#1986
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-29from
tom/refactor-miles/op13-32

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 30, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 50b22eb to 7d6cb32 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch 2 times, most recently from 2078843 to e6d5924 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 7d6cb32 to 0b0b754 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from e6d5924 to c387a20 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 0b0b754 to 2b34861 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from c387a20 to ff23609 Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 2b34861 to dbde692 Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from ff23609 to 3bce5cf Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch 2 times, most recently from 7e77aef to 3a78611 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch 2 times, most recently from 29878b5 to 81e567f Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 3a78611 to 1bea023 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from 81e567f to de73dc2 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 1bea023 to a8e7ad4 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from de73dc2 to 49769ef Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch 2 times, most recently from 7daaae9 to 91d70ba Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from 018f10e to b06d74b Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch 6 times, most recently from f3f12ec to 9f86ef5 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from 7416806 to da1f506 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 9f86ef5 to ba8f4c1 Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from da1f506 to d21f28c Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from ba8f4c1 to 5584b36 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from d21f28c to 7fc17f9 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch 2 times, most recently from 7733925 to 1847829 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from 7fc17f9 to 0d42baa Compare August 13, 2026 06:39
@fzyzcjy
Forbid positional arguments when constructing ray actors
70e4a55 
Every actor constructor call site now passes keyword arguments only, and
the constructors enforce it with keyword-only signatures. A launch layer
that builds workers from a spec can then describe any constructor as a
plain kwargs dict, with no positional-argument channel to carry.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-29 branch from 0d42baa to f9a8ed4 Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-32 branch from 1847829 to 70e4a55 Compare August 14, 2026 04:46
@guapisolo

guapisolo commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

P1 — unresolved at safe checkpoint #2176 and current tip #2649. This PR establishes a kwargs-only Ray actor-constructor contract, but two core actors still keep a positional channel: _PrometheusCollector uses .remote(args) with __init__(self, args), and _HttpPosterActor uses .remote(per_actor_conc) with __init__(self, concurrency). No later incremental PR repairs either pair. Please make both constructors keyword-only and pass args=args / concurrency=per_actor_conc before treating #2176 as the safe merge checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@guapisolo guapisolo Awaiting requested review from guapisolo guapisolo is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo