Skip to content

Delete the external-engine path from SGLangEngine - #1981

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-25from
tom/refactor-miles/op13-26
Open

Delete the external-engine path from SGLangEngine#1981
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-25from
tom/refactor-miles/op13-26

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 9f42682 to faf1d92 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 3123a8f to cbadb7c Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from a21e6bb to e7ef372 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from cbadb7c to 8927d52 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from e7ef372 to 49d21a0 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 8927d52 to 7d2f201 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 49d21a0 to b11c809 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 7d2f201 to 5a0bca3 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from b11c809 to 43fca99 Compare August 6, 2026 03:47
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 3beb445 to d86a0fc Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from ae51901 to d2d561e Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from d86a0fc to 1a9320a Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from d2d561e to 5691205 Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 1a9320a to 206c9ba Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 5691205 to bfb3d73 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 3 times, most recently from b4c1d1f to b730093 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 633513e to eb3a20b Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from b730093 to 2d05a0e Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from eb3a20b to f70d7fc Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 2d05a0e to 1470458 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from f70d7fc to 6e6710d Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 69ed1e9 to ae5f05d Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 72f4ced to ca0568c Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch 2 times, most recently from 71a07e1 to ac8a098 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch 2 times, most recently from 8cba362 to 8490768 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from ac8a098 to 3cf0e02 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from 8490768 to d85d452 Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 3cf0e02 to 9dcccc7 Compare August 14, 2026 04:46

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in stack context: PR #1981’s orphan external-check computation and stale tuple-unpacking test helper are both fixed by PR #2096, before #2176, and the corrected files remain unchanged through checked tip #2649.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-25 branch from d85d452 to c2c713c Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-26 branch from 9dcccc7 to 6fed792 Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants