Skip to content

Add worker specs describing how each worker kind is launched - #1978

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-9from
tom/refactor-miles/op13-1
Open

Add worker specs describing how each worker kind is launched#1978
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-9from
tom/refactor-miles/op13-1

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 30, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 84adb0e to 6543721 Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 4cd62de to 6755420 Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 6543721 to 1675f63 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 6755420 to b87999f Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 1675f63 to 3ff0f15 Compare August 4, 2026 06:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from b87999f to 1d546eb Compare August 4, 2026 06:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 3ff0f15 to 058d4f7 Compare August 4, 2026 07:23
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 1d546eb to 6ac461e Compare August 4, 2026 07:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 058d4f7 to 0ff33e9 Compare August 4, 2026 07:30
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 6ac461e to dc0fd19 Compare August 4, 2026 07:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 0ff33e9 to 2c34e9b Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch 2 times, most recently from 5b68aa9 to aedd9b1 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch 2 times, most recently from 867fd66 to 0d3e27d Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from aedd9b1 to fbc2571 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 0d3e27d to fc51abf Compare August 10, 2026 05:59
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from fbc2571 to 0156227 Compare August 10, 2026 06:05
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from fc51abf to 978b4a4 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 0156227 to 99a50e5 Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 978b4a4 to 82aefc8 Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch 2 times, most recently from 67c4e17 to 5fae70f Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch 2 times, most recently from 2383546 to 4e5de7e Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 5fae70f to 5d6141a Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 4e5de7e to 0c9c76f Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch 2 times, most recently from 3522c63 to 6efffd1 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch 2 times, most recently from 2268a33 to b8244db Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 641d027 to b19cf63 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch 2 times, most recently from 7966dbb to c912081 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from b19cf63 to 015ce25 Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from c912081 to ceddb5e Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch 2 times, most recently from 8b005fd to 78991bf Compare August 14, 2026 04:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from ceddb5e to 7485670 Compare August 14, 2026 04:46
guapisolo
guapisolo approved these changes Aug 26, 2026
View reviewed changes

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in stack context: #1978 moves worker launch knowledge into declarative specs, giving the later worker-manager PRs a common boundary before safe-merge checkpoint #2176. That boundary remains in use through the checked #2649 tip.

@fzyzcjy
Add worker specs describing how each worker kind is launched
e960b66 
Introduce miles.utils.workers.worker_spec with BaseWorkerSpec plus the
command and serve variants, so upper layers can describe workers to a
worker manager without the core packages knowing how processes appear.
PortInfo carries num_consecutive so a spec can reserve a port block
(e.g. the sglang dist-init ports), and ServeWorkerSpec injects the rpc
port in a validator: serve workers always run the rpc server, so a
forgotten declaration must not produce an unreachable worker.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-1 branch from 7485670 to e960b66 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-9 branch from 78991bf to 7f668aa Compare August 29, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guapisolo guapisolo guapisolo approved these changes
@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper jybsuper is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu
@Ying1123 Ying1123 Awaiting requested review from Ying1123
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo