[TOP 2/N] Add batch-invariant scorer integration coverage - #1964
Closed
kaixih wants to merge 4 commits into
Closed
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
|
Closing this test-only split because no additional Miles runtime integration is required. Megatron-LM's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add one GPU integration test for the existing Miles true-on-policy scorer.
With Megatron batch-invariant mode enabled, the scorer keeps its existing path:
The test uses BF16 logits with the DSV4 129280-token vocabulary. It verifies
that Miles reaches Megatron's registered BI
log_softmaximplementation andthat the same row scored alone or in a 17-row batch produces a bitwise-identical
selected-token logprob.
Scope
This is split 2/N from #1788 and is orthogonal to #1912.
Validation
stage-b-2-gpu-h200CI.