Skip to content

docker: keep the cu12 dependency markers after checking out sglang-miles #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yueming-yuan merged 1 commit into from
Jul 30, 2026
Merged

docker: keep the cu12 dependency markers after checking out sglang-miles #1961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,22 @@ RUN rm -rf /root/.cache/pip /root/flash-attention
# ====================================== Install sglang-miles ============================================

# Install sglang from sglang-miles branch
# The CUDA 12 sglang images sed their dependency markers from cu13 to cu12 in
# python/pyproject.toml and never commit it, so a plain checkout aborts on the dirty
# file. Force it, then re-apply the same rewrite: the tree we just checked out carries
# the cu13 markers, and sglang's editable install makes them visible to every later pip
# resolve, which would drag cu13 packages onto a cu12 image.
RUN cd /sgl-workspace/sglang && \
git fetch origin ${SGLANG_BRANCH} && \
if [ -n "${SGLANG_COMMIT}" ]; then \
git checkout ${SGLANG_COMMIT}; \
git checkout -f ${SGLANG_COMMIT}; \
else \
git checkout FETCH_HEAD; \
git checkout -f FETCH_HEAD; \
fi && \
if [ "${ENABLE_CUDA_13}" != "1" ]; then \
sed -i 's/cuda-python>=13\.0/cuda-python>=12,<13/' python/pyproject.toml && \
sed -i 's/flashinfer_python\[cu13\]/flashinfer_python[cu12]/' python/pyproject.toml && \
sed -i 's/nvidia-cutlass-dsl\[cu13\]/nvidia-cutlass-dsl/' python/pyproject.toml; \
fi && \
pip install -e "python[all]" --no-deps

Expand Down
Loading