refactor(examples)(temp): leave fully_async out of the reorg - #1954
refactor(examples)(temp): leave fully_async out of the reorg#1954Zhichenzzz wants to merge 1 commit into
Conversation
Stacked on shi/260729-examples-reorg. Restores every fully_async path to its state on main, so this reorg no longer touches fully_async. Two reasons to hold it back: 1. PR #1716 moves examples/fully_async/fully_async_rollout.py to miles/rollout/fully_async_rollout.py, promoting it into the core library and rewriting --rollout-function-path from the bare module name to the fully qualified miles.rollout.fully_async_rollout.generate_rollout_fully_async. The reorg moved the same file to examples/infra_features/fully_async/ instead. Whichever landed second would conflict, or silently undo the other. 2. The reorg deleted content with no replacement anywhere in the tree: docs/examples/fully-async.md (205 lines), run-qwen3-4b-fully_async.sh (142 lines), run_qwen3_30b_a3b_fully_async.py (176 lines) and examples/fully_async/README.md (45 lines), against 43 lines added back as a new README. docs/user-guide/fully-async.md gained only 2 net lines, all link rewrites, so none of the deleted material was folded into it. Also fixes the references that pointed at the moved directory and would otherwise dangle: train_async.py, examples/infra_features/random_async/README.md and its rollout module now point at examples/fully_async/ again, and the examples/README.md entry moves to the top level list with its path corrected. The docs/examples/index.md link to /user-guide/fully-async is left as the reorg set it. That page exists either way, and the reworded question reads better than the original. Once #1716 lands, moving what remains of examples/fully_async/ (a README and two launch scripts) under infra_features/ is a small independent change, with the rollout module already living in core and out of the way.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Superseded by 84bf09c on the base branch, which does everything this PR did. Closing. Verified against the current tip of
Rebasing this branch onto that tip leaves an empty diff, with the only conflict being a Two things your revert caught that this PR missed, worth recording:
You also fully reverted the The sequencing suggestion stands: land #1716 first, then moving what remains of |
Stacked on #1953 (
shi/260729-examples-reorg). Restores every fully_async path to its stateon
main, so the reorg no longer touches fully_async. Please squash this into #1953, or mergeit into that branch, whichever you prefer.
Why hold fully_async back
1. It collides with #1716. That PR promotes the rollout module into the core library:
#1716 also rewrites
--rollout-function-pathfrom the bare module namefully_async_rollout.generate_rollout_fully_asyncto the fully qualifiedmiles.rollout.fully_async_rollout.generate_rollout_fully_async, which removes the existingdependency on the example directory being on
sys.path. Six files are edited by both PRs, sowhichever lands second would conflict, or silently undo the other.
2. Content was deleted with no replacement. Nothing in the tree recreates these:
docs/examples/fully-async.mdexamples/fully_async/run_qwen3_30b_a3b_fully_async.pyexamples/fully_async/run-qwen3-4b-fully_async.shexamples/fully_async/README.mdexamples/infra_features/fully_async/README.mddocs/user-guide/fully-async.mdgained 2 net lines, all link rewrites, so none of the deletedmaterial was folded into it. That leaves the feature with no runnable recipe and no examples
docs page.
What this PR does
Restores to their
mainstate:docs/examples/fully-async.md,docs/user-guide/fully-async.md, and all four files underexamples/fully_async/. Dropsexamples/infra_features/fully_async/. Restores theexamples/fully-asyncnavigation entry indocs/docs.jsonand the Card indocs/examples/index.md.It also repairs the references that would otherwise dangle once that directory is gone:
train_async.pyexamples/infra_features/random_async/README.mdand its rollout moduleexamples/README.md, where the entry moves to the top level list with its path correctedVerified that the fully_async paths are now byte identical to
main, that no reference toinfra_features/fully_asyncremains anywhere in the repository, thatdocs.jsonstill parses,and that pre-commit passes on every touched file.
Left alone deliberately
The
docs/examples/index.mdlink to/user-guide/fully-asyncstays as you set it. That pageexists either way, and the reworded question reads better than the original.
Suggested sequencing
Land #1716 first, since it is 11 files and unambiguous. Once it is in, moving what remains of
examples/fully_async/(a README and two launch scripts) underinfra_features/is a smallindependent change, with the rollout module already in core and out of the way.