Skip to content

Expire finished calls that were never retrieved - #1952

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-14from
tom/refactor-miles/op9-15
Open

Expire finished calls that were never retrieved#1952
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-14from
tom/refactor-miles/op9-15

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from 57c499d to 268e46c Compare July 30, 2026 09:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from 01e3965 to df3e51f Compare August 3, 2026 23:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from 268e46c to 4e70a12 Compare August 3, 2026 23:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from df3e51f to dc55cff Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from 4e70a12 to 1f72ebc Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from dc55cff to fb68b0b Compare August 4, 2026 06:58
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch 2 times, most recently from adb1caa to dd88fa0 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from fb68b0b to 85c8082 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from dd88fa0 to ff5d591 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 8f42629 to 726396a Compare August 10, 2026 06:08
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch 2 times, most recently from 82d9cdb to f490c5f Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from aa7b221 to b7827b7 Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch 2 times, most recently from 5ed2c39 to f5d8d99 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 4849ba2 to a7c10d6 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from f5d8d99 to 407c863 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from a7c10d6 to 868a9f6 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from 407c863 to 60e41a3 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 868a9f6 to 79226dd Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from 60e41a3 to 6e3788d Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 79226dd to 5f0a04f Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch 2 times, most recently from 3bf836e to c10abc9 Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 145b8fa to 630d5ee Compare August 13, 2026 06:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-15 branch from c10abc9 to 084464f Compare August 13, 2026 06:40
A record used to live until its result was collected, so a call whose
result nobody ever polls for stayed in the store forever. Stamp the
finish time and give every finished record an absolute twelve hour ttl.

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in stack context: #1952 fixes the unbounded retention of finished, unpolled RPC calls from #1942 by adding a finished-record TTL. The repair lands before safe-merge checkpoint #2176 and remains present through the checked #2649 tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants