Support worker env vars before importing the server - #1951
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
5ec98e3 to
79b3d6d
Compare
01e3965 to
df3e51f
Compare
79b3d6d to
c83968d
Compare
dc55cff to
fb68b0b
Compare
b83797f to
ee21cc3
Compare
fb68b0b to
85c8082
Compare
ee21cc3 to
a59b6c3
Compare
8f42629 to
726396a
Compare
a59b6c3 to
f7b9f90
Compare
726396a to
aa7b221
Compare
489491a to
e21c2f4
Compare
aa7b221 to
b7827b7
Compare
e21c2f4 to
9b9f125
Compare
b7827b7 to
4849ba2
Compare
9b9f125 to
e541ccd
Compare
4849ba2 to
a7c10d6
Compare
e541ccd to
dd1ec82
Compare
868a9f6 to
79226dd
Compare
1358263 to
f2cac12
Compare
79226dd to
5f0a04f
Compare
f2cac12 to
8e2f45a
Compare
5f0a04f to
145b8fa
Compare
8e2f45a to
851e76b
Compare
630d5ee to
bf6d3c6
Compare
guapisolo
left a comment
There was a problem hiding this comment.
[P1][Unresolved through #2649] serve.py writes the complete own/worker argv, computed environment values, and exec argv to stdout; #2446 also wires this entrypoint into the Helm production launch path. Please log only non-sensitive phase metadata, identities, or counts, and add a sentinel-secret test proving neither argv nor environment values reach the logs.
[P2][Fixed only after checkpoint by #2345] This remains broken at the #2176 checkpoint. #2345 removes the hidden inner CLI contract by moving both entrypoints onto the shared --specs/--pool-id parser, so #2345 or an equivalent correction must land with the checkpoint.
[P2][Unresolved through #2649] The exec chain still rebuilds [sys.executable, "-m", ...], so Python flags such as -O, -u, -I, -E, and -X are dropped. Please preserve the interpreter-option prefix from sys.orig_argv while replacing only the module target, and cover one observable flag in a subprocess test.
bf6d3c6 to
cca9384
Compare
No description provided.