Skip to content

Support worker env vars before importing the server - #1951

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-16from
tom/refactor-miles/op9-14
Open

Support worker env vars before importing the server#1951
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-16from
tom/refactor-miles/op9-14

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from 5ec98e3 to 79b3d6d Compare July 30, 2026 09:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from 01e3965 to df3e51f Compare August 3, 2026 23:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from 79b3d6d to c83968d Compare August 3, 2026 23:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from dc55cff to fb68b0b Compare August 4, 2026 06:58
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch 2 times, most recently from b83797f to ee21cc3 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from fb68b0b to 85c8082 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from ee21cc3 to a59b6c3 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from 8f42629 to 726396a Compare August 10, 2026 06:08
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from a59b6c3 to f7b9f90 Compare August 10, 2026 06:08
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 726396a to aa7b221 Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch 2 times, most recently from 489491a to e21c2f4 Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from aa7b221 to b7827b7 Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from e21c2f4 to 9b9f125 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from b7827b7 to 4849ba2 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from 9b9f125 to e541ccd Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 4849ba2 to a7c10d6 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from e541ccd to dd1ec82 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from 868a9f6 to 79226dd Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from 1358263 to f2cac12 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 79226dd to 5f0a04f Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from f2cac12 to 8e2f45a Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from 5f0a04f to 145b8fa Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-16 branch from 8e2f45a to 851e76b Compare August 13, 2026 06:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch 2 times, most recently from 630d5ee to bf6d3c6 Compare August 14, 2026 04:45

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1][Unresolved through #2649] serve.py writes the complete own/worker argv, computed environment values, and exec argv to stdout; #2446 also wires this entrypoint into the Helm production launch path. Please log only non-sensitive phase metadata, identities, or counts, and add a sentinel-secret test proving neither argv nor environment values reach the logs.

[P2][Fixed only after checkpoint by #2345] This remains broken at the #2176 checkpoint. #2345 removes the hidden inner CLI contract by moving both entrypoints onto the shared --specs/--pool-id parser, so #2345 or an equivalent correction must land with the checkpoint.

[P2][Unresolved through #2649] The exec chain still rebuilds [sys.executable, "-m", ...], so Python flags such as -O, -u, -I, -E, and -X are dropped. Please preserve the interpreter-option prefix from sys.orig_argv while replacing only the module target, and cover one observable flag in a subprocess test.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-14 branch from bf6d3c6 to cca9384 Compare August 29, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants