Carry rich argument and result types and refuse ambiguous signatures - #1949
Merged
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 29, 2026 14:01
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
August 3, 2026 23:45
fede198 to
c77ca27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 3, 2026 23:45
bc9feb9 to
545a19e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 4, 2026 00:39
c77ca27 to
5b7c618
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 4, 2026 06:58
130d788 to
b68e06c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
August 6, 2026 07:03
99bfb8d to
752a5d1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 6, 2026 07:03
b68e06c to
5815c08
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 9, 2026 23:33
752a5d1 to
9bd5a94
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 10, 2026 06:08
541f50d to
271be23
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 10, 2026 06:08
9bd5a94 to
82846c5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 10, 2026 16:07
271be23 to
4825078
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 10, 2026 16:07
82846c5 to
092d9a6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 10, 2026 16:34
4825078 to
dc50e2e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
August 12, 2026 02:48
4d7f71d to
edab1c6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 12, 2026 14:31
6715989 to
ed5cfad
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
3 times, most recently
from
August 13, 2026 01:13
824f718 to
be60cbd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 13, 2026 03:25
be60cbd to
715f1a1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
2 times, most recently
from
August 13, 2026 06:01
6883be7 to
bfd1ee4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
August 13, 2026 06:40
aeac314 to
b3500ab
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
2 times, most recently
from
August 14, 2026 04:46
518de3e to
9d47dea
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 14, 2026 04:46
b3500ab to
772c687
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
August 29, 2026 12:40
9d47dea to
ba0cda6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
August 29, 2026 12:40
772c687 to
3c35c8b
Compare
fzyzcjy
commented
Aug 30, 2026
fzyzcjy
left a comment
fzyzcjy
left a comment
Collaborator
Author
There was a problem hiding this comment.
No correctness or regression issue introduced by this op remains at deliver-1 within the requested scope. Deliver-2 changes address later integration requirements rather than a blocker for this op.
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
September 1, 2026 10:03
a096f13 to
789f4fb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
September 1, 2026 10:36
286e258 to
67c3b46
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
3 times, most recently
from
September 3, 2026 06:21
d63561d to
bab871b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
September 3, 2026 07:53
9ff35f9 to
75281be
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
September 3, 2026 07:53
bab871b to
35cbc1f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
September 4, 2026 00:53
75281be to
b2e43c6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
2 times, most recently
from
September 4, 2026 03:28
86be128 to
ed98362
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-12
branch
from
September 4, 2026 05:25
1b86716 to
4c67dd1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op9-13
branch
from
September 4, 2026 05:25
ed98362 to
aa35f40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.