Skip to content

Refuse a duplicate call id with 409 instead of running it twice - #1947

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-8from
tom/refactor-miles/op9-9
Open

Refuse a duplicate call id with 409 instead of running it twice#1947
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op9-8from
tom/refactor-miles/op9-9

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist

gemini-code-assist Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 29, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 3913ee0 to a3aebc4 Compare July 30, 2026 09:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch 2 times, most recently from 105e398 to f7c81ec Compare August 3, 2026 23:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch 2 times, most recently from d0d0421 to deccfea Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from f7c81ec to 38e14c9 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from deccfea to 0d42933 Compare August 4, 2026 06:58
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 38e14c9 to 8982b44 Compare August 4, 2026 06:58
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 0d42933 to d8781ac Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 8982b44 to c18b7d4 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from d8781ac to b715079 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from c18b7d4 to 8988317 Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from b715079 to 2904afd Compare August 10, 2026 06:08
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch 2 times, most recently from f024ed7 to b029ca5 Compare August 10, 2026 16:07
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch 2 times, most recently from 63021fa to 7ffb549 Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch 2 times, most recently from b769302 to 7bdba5f Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 7ffb549 to 6fc4348 Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 7bdba5f to 5e1d9bc Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 6fc4348 to 1d08b92 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch 2 times, most recently from 7bbcf87 to 6040ebf Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 0d58719 to 4a8a303 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 6040ebf to 45ff18e Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from 4a8a303 to ce0262d Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 45ff18e to 691ffc4 Compare August 13, 2026 06:01
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from ce0262d to f10603c Compare August 13, 2026 06:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 691ffc4 to 2816b1b Compare August 13, 2026 06:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from f10603c to dd424ba Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 2816b1b to 73c5309 Compare August 14, 2026 04:46
@guapisolo guapisolo mentioned this pull request Aug 25, 2026
Open
guapisolo
guapisolo approved these changes Aug 25, 2026
View reviewed changes

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in stack context through safe-merge checkpoint #2176. PR #1947 rejects duplicate call IDs before execution while keeping the original call pollable; no actionable issues found.

@fzyzcjy
Refuse a duplicate call id with 409 instead of running it twice
c8ce6f6 
The call id is generated by the client, so a resubmit is the shape a
retried submit would take. The store reserves the id for as long as it
retains the outcome, and a second submit under a known id is rejected
rather than starting the work again.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-9 branch from 73c5309 to c8ce6f6 Compare August 29, 2026 12:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op9-8 branch from dd424ba to 9c429cd Compare August 29, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guapisolo guapisolo guapisolo approved these changes
@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper jybsuper is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo