Remove the experimental swe-agent examples - #1918
Merged
Merged
Conversation
…-agent The maintained Harbor recipe was promoted to examples/swe-agent in #1741, so the three copies under examples/experimental/ are now either duplicates of it or dead code, and the docs pointed readers at a directory we no longer want them to use. experimental/swe-agent was the original Nemo-Gym-based generation (last real change 2026-03-25) and carried the repo's only two git submodules, both pointing at personal forks; removing it empties .gitmodules, so that file goes too. experimental/swe-agent-v2 is the tree that was promoted, and experimental/swe-agent-v2-amd was a near-copy of it for AMD. Every doc reference now points at examples/swe-agent.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
guapisolo
approved these changes
Jul 28, 2026
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. time to say goodbye to old files
nblintao
approved these changes
Jul 28, 2026
5 tasks
nblintao
added a commit
that referenced
this pull request
Jul 29, 2026
…ion TITO chain New examples/experimental/nemo-gym recipe integrating NVIDIA-NeMo/Gym as an external environment ecosystem at the agent-function layer, the same shape as the Harbor and OpenEnv connectors: the session server records every chat-completions turn losslessly, and a thin agent function POSTs each sample to the sandbox-backed mini_swe_agent_2 agent with policy_base_url set to the session URL (the per-request override proposed in NVIDIA-NeMo/Gym#2166; the README points at that PR's branch until it merges). - nemogym_agent_function.py: one POST /run per sample; sampling kwargs mapped onto responses_create_params (temperature / top_p / max_output_tokens), the only channel mini_swe_agent_2 reads; no miles imports so it loads on CPU-only machines - nemogym_generate.py: reward hook reading the environment's grade - eval_nemogym_via_api.py + tests/: no-GPU validation — offline unit tests of the /run contract, a golden scan (gold patch through the sandbox + SWE-bench harness, no model), and an API-policy scan that drives real episodes through the same policy_base_url override - run.py: the validated GPU launcher (requires MILES_EXPERIMENTAL_ROLLOUT_REFACTOR=1, which gates the dynamic registration of the agentic flags) - user-guide docs: nemo-gym page, environments tables (agent-function connector row; NeMo-Gym's own sandbox provider API supports Daytona) Validated end-to-end: offline contract tests; a golden scan scoring 1.0 in the official SWE-bench container; a DeepSeek API-policy episode; and a 4x H200 GRPO training smoke (Qwen3-4B-Instruct-2507, SWE-bench Verified) whose episodes ran in real task containers with the official harness grading them and rewards flowing back into training. Known limitations are documented in the README: the official swebench package lacks eval specs for several SWE-Gym repos (train on SWE-bench-family instances until that gap closes), and Qwen3 templates trip the tito_session_mismatch soft diagnostic (empty <think> skeleton on re-rendered assistant history; engine-recorded tokens stay lossless). This supersedes the fork-based NeMo-Gym integration removed in #1918: same ecosystem, now driven through upstream NVIDIA-NeMo/Gym with no submodules and lossless token recording. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all three swe-agent examples under
examples/experimental/and repoints every doc reference atexamples/swe-agent.examples/experimental/swe-agent— the original Nemo-Gym-based generation. Last substantive change was 2026-03-25, and it was the only thing in the repo using git submodules.examples/experimental/swe-agent-v2— the Harbor recipe that was promoted toexamples/swe-agentin Add examples/swe-agent: GLM-4.7-Flash agentic training with Harbor #1741.examples/experimental/swe-agent-v2-amd— a near-copy of the above for AMD..gitmodulesis deleted as well: its only two entries were the submodules belonging to the first directory, both pointing at personal forks, so the file is empty once that tree is gone. Clones no longer need--recurse-submodules.Why
examples/experimental/swe-agent-v2was described in the docs as "the maintained recipe" for Harbor training, but it lived under a directory whose README says the contents are "not fully verified, only for experimental use". #1741 promoted it toexamples/swe-agent, so keeping the experimental copies means two divergent copies of the same recipe and docs that send readers to the one we no longer want them to use.The other two directories are not superseded so much as finished: the Nemo-Gym example targets an environment the repo no longer integrates with, and the AMD variant is a fork of the promoted tree.
What is not carried over
examples/swe-agentcovers the GLM-4.7-Flash Harbor path (sync + fully-async launchers). These files existed only in the removed trees and have no equivalent there, so this PR does drop them:All of it stays in git history and can be restored or promoted separately if any of it is still wanted. Flagging it explicitly because it is easy to miss in a deletion-only diff.
Docs updated
docs/user-guide/harbor.md,docs/user-guide/agentic-chat-template.mdanddocs/user-guide/rollout-endpoints.mdall pointed at the experimental path; they now point atexamples/swe-agent. One docstring cross-reference in the OpenEnv example was updated for the same reason.Test plan
git grepfinds zero remaining references to the removed paths anywhere in the tree.gitmodulesis empty after the submodule paths are removed, and no gitlink entries remain in the indexexamples/swe-agentis untouched by this PRuvx ruff checkpasses on the one modified Python file