Add assertions to reject training data generated under the sglang default weight version - #1894
Open
fzyzcjy wants to merge 1 commit into
Open
Add assertions to reject training data generated under the sglang default weight version#1894fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 28, 2026 13:52
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
July 29, 2026 04:10
e4de483 to
b7ac6fc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
2 times, most recently
from
August 3, 2026 23:43
aea9173 to
5944546
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 4, 2026 00:38
09fcdad to
8915cff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
2 times, most recently
from
August 4, 2026 06:52
7487e46 to
267cd10
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
2 times, most recently
from
August 6, 2026 07:03
4834d96 to
6665c38
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
from
August 6, 2026 07:03
267cd10 to
72943b4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 9, 2026 23:31
6665c38 to
e3047fa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
2 times, most recently
from
August 10, 2026 05:59
b751307 to
fe83e47
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 10, 2026 05:59
e3047fa to
dfd4a0b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
from
August 10, 2026 16:06
fe83e47 to
21f9374
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
2 times, most recently
from
August 10, 2026 16:33
0dcbfaf to
f74ffb6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
3 times, most recently
from
August 12, 2026 14:31
80d85c5 to
f5965ec
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 12, 2026 14:31
198de11 to
daba386
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 12, 2026 23:56
daba386 to
f21da15
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
2 times, most recently
from
August 13, 2026 01:13
d1f6d17 to
d3ed573
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 13, 2026 03:25
8be9654 to
e2b0e70
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
from
August 13, 2026 03:25
d3ed573 to
2c79fef
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-8
branch
from
August 13, 2026 06:00
e2b0e70 to
1f9b0c7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
from
August 13, 2026 06:00
2c79fef to
11415e1
Compare
…ault weight version Every span on incoming training samples must differ from the sglang "default" placeholder and match the numeric pattern miles stamps on weight updates; debug modes and LoRA are exempt. Covered by pure function tests and a manager-level regression.
fzyzcjy
force-pushed
the
tom/refactor-miles/op1-14
branch
from
August 14, 2026 04:45
11415e1 to
e50957c
Compare
guapisolo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837