Key a server's cells by a globally unique string id instead of numerical indices - #1887
Open
fzyzcjy wants to merge 1 commit into
Open
Key a server's cells by a globally unique string id instead of numerical indices#1887fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 28, 2026 12:58
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
from
July 28, 2026 13:31
f9b8fd0 to
e1a85ce
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 3, 2026 23:45
167be33 to
dddd8e5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
2 times, most recently
from
August 4, 2026 00:39
2c49d90 to
fd39325
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 4, 2026 06:58
45cf737 to
97ff839
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
from
August 4, 2026 06:58
fd39325 to
b1169c7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 6, 2026 07:03
97ff839 to
552c914
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
from
August 6, 2026 07:03
b1169c7 to
0802de3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 10, 2026 06:08
552c914 to
82524e5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
2 times, most recently
from
August 10, 2026 16:07
d013498 to
b9370a6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 10, 2026 16:34
14ccb82 to
6c87ae0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
2 times, most recently
from
August 12, 2026 02:48
0957c83 to
a6eac6e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 12, 2026 14:31
9b10065 to
c152f6b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
from
August 12, 2026 14:31
a6eac6e to
ac9ec83
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 12, 2026 23:56
c152f6b to
f5ebfd9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
3 times, most recently
from
August 13, 2026 03:25
e4239e6 to
93d272d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 13, 2026 06:01
04a3e1f to
8081afc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
2 times, most recently
from
August 14, 2026 04:46
7f90422 to
67e42b2
Compare
guapisolo
approved these changes
Aug 25, 2026
…cal indices server_cells becomes a dict keyed by "<model name>-<index>", which the cell also carries so its logs name it. The id is unique across models, so the control plane addresses a cell by that id alone: start_cell and stop_cell take it, find the one server that holds it, and get_cell_indexer_of_id_map -- whose positional ids were only stable while the topology was -- goes away with list_cell_ids in its place. A cell handle now composes its name from cell_type and cell_key rather than owning the whole string, so the rollout handle can key on the cell id while the actor handle keeps keying on its index. The string id is what elastic backends (k8s, external rollout) will supply; an int position cannot survive a cell being replaced.
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-3
branch
from
August 29, 2026 12:40
12e3cd4 to
b2bc15e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-1
branch
from
August 29, 2026 12:40
67e42b2 to
469c083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837