Move has_new_engines to RolloutServer - #1882
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
July 28, 2026 13:31
7493517 to
cfe8621
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
3 times, most recently
from
August 4, 2026 00:39
eaae7fb to
81bc995
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 4, 2026 06:57
0e9f0d5 to
5510389
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
from
August 4, 2026 06:58
81bc995 to
465bc35
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 6, 2026 07:03
5510389 to
c70d67b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
from
August 6, 2026 07:03
465bc35 to
360f52d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 10, 2026 06:07
c70d67b to
00bb032
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
from
August 10, 2026 06:07
360f52d to
2f35ca3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 10, 2026 16:07
00bb032 to
a3a3f81
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
4 times, most recently
from
August 12, 2026 14:31
94f5ea7 to
62842c9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
2 times, most recently
from
August 12, 2026 23:56
167d712 to
ff2dd3a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
3 times, most recently
from
August 13, 2026 03:25
c6a11aa to
dcbc1e6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 13, 2026 06:01
81fdc60 to
d0044dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
from
August 13, 2026 06:01
dcbc1e6 to
013fd45
Compare
Lift has_new_engines from ServerGroup to RolloutServer: recover now returns the cells it restarted, and the server aggregates the flag from what startup and recovery report instead of polling the groups. This is behaviour preserving -- the group already set the flag itself on both paths -- but it puts the flag next to the only consumer that reads it. Drop the two registration tests along with it: they assert a skip for a missing router and for external engines, and neither gate exists any more now that a router is assumed to be present and external mode raises before a cell is ever allocated.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-17
branch
from
August 14, 2026 04:46
d0044dd to
33ff0ae
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-25
branch
from
August 14, 2026 04:46
013fd45 to
260e5e7
Compare
guapisolo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837