Address workers by cell index and let the cell describe itself to the router - #1880
Open
fzyzcjy wants to merge 1 commit into
Open
Address workers by cell index and let the cell describe itself to the router#1880fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
July 28, 2026 13:31
b69a8f7 to
c916396
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
July 28, 2026 13:31
321e282 to
92a733e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 3, 2026 23:45
c916396 to
d9f5adc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 3, 2026 23:45
92a733e to
a9eb34e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 4, 2026 00:39
d9f5adc to
ec352af
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 4, 2026 06:57
04e65d7 to
975ce31
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
2 times, most recently
from
August 6, 2026 07:03
9d10f8b to
e37c198
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 10, 2026 06:07
81ebf4e to
c326b1e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
2 times, most recently
from
August 10, 2026 16:07
a7528da to
d903659
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 10, 2026 16:34
39948d0 to
9ed4407
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 12, 2026 02:48
6550b6b to
fa7b944
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 12, 2026 14:31
081b08f to
ac37584
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 12, 2026 14:31
fa7b944 to
9fe573d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 12, 2026 23:56
ac37584 to
045a39b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 12, 2026 23:56
9fe573d to
03f81c5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 13, 2026 01:13
045a39b to
ff36578
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-24
branch
from
August 13, 2026 03:25
4995de7 to
df3cb3e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
2 times, most recently
from
August 13, 2026 06:01
2fb2661 to
ccfb2cc
Compare
… router The router only ever hears about one primary engine per cell, so callers were flattening cell indices into engine indices purely for the callee to filter them back down via a modulo check. register_workers, unregister_workers, mark_alive and the start_engines return value now all speak cell indices, and the per-cell payload (url, worker type, bootstrap port, legacy-api flag) moves into ServerCell.register / .unregister -- the group keeps only the router connection and the gating.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-23
branch
from
August 14, 2026 04:45
ccfb2cc to
d6616bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837