Make start_engines async and await engine init inside it - #1876
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
July 28, 2026 13:31
df3e2ef to
6dcfbd7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 3, 2026 23:44
8049dac to
dc38c1c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
2 times, most recently
from
August 4, 2026 00:39
69a82f8 to
da8a37d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 4, 2026 06:57
cdc8c1f to
23c20fa
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 4, 2026 06:57
da8a37d to
7cecf83
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 6, 2026 07:03
23c20fa to
f465bcd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 6, 2026 07:03
7cecf83 to
eb791e9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 10, 2026 06:07
f465bcd to
e34f5f9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
3 times, most recently
from
August 10, 2026 16:34
f2c73a2 to
d15cdac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 12, 2026 02:48
1fb4d92 to
d31c66c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
5 times, most recently
from
August 13, 2026 03:25
9175c4b to
828246e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 13, 2026 06:01
80f1dd4 to
fd62164
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 13, 2026 06:01
828246e to
5acf6a2
Compare
start_engines now awaits its engines' init and returns only the new engine indices; recover drops its separate gather, and start_rollout_servers submits one start future per group and collects them with wait_futures. Actor creation, port allocation and state marking all sit before the first await point, so concurrently running starts cannot double-allocate a slot, and port allocation stays serialized because alloc's blocking ray.get never yields the loop. Squashed commits: - Make start_engines async and await engine init inside it - Apply black auto-fix
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 14, 2026 04:45
fd62164 to
f666bf2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 14, 2026 04:45
5acf6a2 to
ceb9c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837