Add PortAllocator.alloc and thread the shared allocator through allocation - #1872
Open
fzyzcjy wants to merge 1 commit into
Open
Add PortAllocator.alloc and thread the shared allocator through allocation#1872fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
from
July 28, 2026 13:31
19e1383 to
ad0099e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
2 times, most recently
from
August 3, 2026 23:45
97cf640 to
c98cff5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
2 times, most recently
from
August 4, 2026 00:39
3a15050 to
db83a17
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
2 times, most recently
from
August 4, 2026 06:58
6e7d155 to
7637998
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:58
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
2 times, most recently
from
August 6, 2026 07:03
aee8181 to
cd98f14
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
2 times, most recently
from
August 10, 2026 06:08
82c96d8 to
0294ac2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
4 times, most recently
from
August 12, 2026 02:48
d0f85d5 to
ec894a6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
from
August 12, 2026 14:31
1c68f0e to
5a2046a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
from
August 12, 2026 14:31
ec894a6 to
1d15a1d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
from
August 12, 2026 23:56
5a2046a to
bd8fd4a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
from
August 12, 2026 23:56
1d15a1d to
416b664
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
from
August 13, 2026 01:13
bd8fd4a to
a15b461
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
2 times, most recently
from
August 13, 2026 03:25
00f5ee9 to
c33ba50
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-7
branch
from
August 13, 2026 06:01
359da2b to
ee3d09b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
from
August 13, 2026 06:01
c33ba50 to
b848c48
Compare
…ation allocate_rollout_engine_addr_and_ports_normal now mutates the caller's PortAllocator via alloc(node_ip) instead of growing a private cursor dict and returning a replacement, which also removes the base_port chaining (assign/next_base_port). alloc keeps the engine's free-port probe: a recovery allocator starts empty, and only the probe prevents it from re-issuing ports that live engines already hold.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-9
branch
from
August 14, 2026 04:45
b848c48 to
b8b7e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837