Extract the Ray actor construction into launch_sglang_ray_actor - #1868
Open
fzyzcjy wants to merge 1 commit into
Open
Extract the Ray actor construction into launch_sglang_ray_actor#1868fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
July 28, 2026 13:31
40b61fb to
7f95ba9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
July 28, 2026 13:31
03c7b85 to
0f6ba81
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 3, 2026 23:45
7f95ba9 to
b28729e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 3, 2026 23:45
0f6ba81 to
805ddc7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 4, 2026 00:39
b28729e to
9e31799
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 4, 2026 00:39
805ddc7 to
328201e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 4, 2026 06:58
9e31799 to
7856256
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:58
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 4, 2026 06:58
328201e to
caa6f9f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 6, 2026 07:03
7856256 to
9b2b0dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 6, 2026 07:03
caa6f9f to
072d6e3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 10, 2026 06:07
9b2b0dd to
c334e14
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
2 times, most recently
from
August 10, 2026 16:07
ad0b248 to
cba62b2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 10, 2026 16:07
c334e14 to
95fdd1e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 10, 2026 16:34
cba62b2 to
ac9ee52
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
2 times, most recently
from
August 12, 2026 02:48
4c50796 to
8240808
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
3 times, most recently
from
August 12, 2026 23:56
be4bfaa to
da97df0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 13, 2026 01:13
b3dc110 to
842a79f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 13, 2026 01:13
da97df0 to
7c49565
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 13, 2026 03:25
842a79f to
b9a2ee9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 13, 2026 03:25
7c49565 to
2dd13f8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 13, 2026 06:01
b9a2ee9 to
55146af
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 13, 2026 06:01
2dd13f8 to
3cd8662
Compare
The free function lives in server_cell.py so later ops can move engine startup onto the cell; start_engines now only decides which slots to fill. Test fixtures patch SGLangEngine at its new home.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-5
branch
from
August 14, 2026 04:46
3cd8662 to
80bf524
Compare
guapisolo
previously approved these changes
Aug 24, 2026
guapisolo
reviewed
Aug 25, 2026
| ) -> ray.actor.ActorHandle: | ||
| pg, reordered_bundle_indices, reordered_gpu_ids = pg | ||
|
|
||
| num_gpus = 0.2 |
Collaborator
There was a problem hiding this comment.
[P1] Ban the RDT path before landing this refactor
RDT is not part of this refactor plan and conflicts directly with the actor-ownership changes in this stack. Do not port the #1313 launch logic into launch_sglang_ray_actor.
Minimal revert instruction:
- Remove
"rdt"from the--update-weight-transfer-modechoices so startup rejects this path. - Resolve this hunk entirely in favor of this PR: drop
rdt_reuse_pg, the RDTnum_gpus=0branch,rdt_pg_kwargs, andpg_bundlesforwarding. - Keep
launch_sglang_ray_actoras the single non-RDT actor-launch path; do not add an RDT compatibility branch.
The remaining unreachable RDT implementation can be removed separately. The acceptance condition here is that --update-weight-transfer-mode rdt is rejected and no RDT-specific rollout-launch behavior survives this rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837