Move engine teardown into ServerCell.stop - #1867
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
July 28, 2026 13:31
1fbe4de to
e5ebd8c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
2 times, most recently
from
August 3, 2026 23:45
7f95ba9 to
b28729e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
2 times, most recently
from
August 4, 2026 00:39
3cc7d15 to
d1bbb13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 4, 2026 00:39
b28729e to
9e31799
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 4, 2026 06:58
d1bbb13 to
9b22eca
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:58
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 4, 2026 06:58
9e31799 to
7856256
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 6, 2026 07:03
9b22eca to
bec5ce3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 6, 2026 07:03
7856256 to
9b2b0dd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 10, 2026 06:07
bec5ce3 to
66955a8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 10, 2026 06:07
9b2b0dd to
c334e14
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 10, 2026 16:07
66955a8 to
10b5470
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 10, 2026 16:07
c334e14 to
95fdd1e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 10, 2026 16:34
10b5470 to
4543046
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 10, 2026 16:34
95fdd1e to
4c50796
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 12, 2026 02:48
4543046 to
cdffae9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 12, 2026 02:48
4c50796 to
8240808
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 12, 2026 14:31
cdffae9 to
3b4c6bc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 12, 2026 14:31
8240808 to
2f09e35
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 12, 2026 23:56
3b4c6bc to
ef554fa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
3 times, most recently
from
August 13, 2026 03:25
842a79f to
b9a2ee9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 13, 2026 06:01
60ed09b to
ee3a910
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 13, 2026 06:01
b9a2ee9 to
55146af
Compare
stop_engines keeps the router unregistration, then converts the flat engine indices into whole cells (asserting full coverage) and stops each. The shutdown timeout moves to server_cell so both modules share it.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 14, 2026 04:46
ee3a910 to
30ace97
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-4
branch
from
August 14, 2026 04:46
55146af to
028906f
Compare
guapisolo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837