Move vanilla methods onto ServerCell - #1866
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
July 28, 2026 13:31
1fbe4de to
e5ebd8c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
2 times, most recently
from
August 3, 2026 23:45
c321277 to
2f3036b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 3, 2026 23:45
e5ebd8c to
3cc7d15
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 4, 2026 00:39
2f3036b to
e835dbd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 4, 2026 00:39
3cc7d15 to
d1bbb13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 4, 2026 06:57
e835dbd to
3dc88c4
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 4, 2026 06:58
d1bbb13 to
9b22eca
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 6, 2026 07:03
3dc88c4 to
ee8c686
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 6, 2026 07:03
9b22eca to
bec5ce3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 10, 2026 06:07
ee8c686 to
d7451ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 10, 2026 06:07
bec5ce3 to
66955a8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 10, 2026 16:07
d7451ff to
3b4b538
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 10, 2026 16:07
66955a8 to
10b5470
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 10, 2026 16:34
3b4b538 to
9c16b82
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
3 times, most recently
from
August 12, 2026 14:31
cdffae9 to
3b4c6bc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 12, 2026 14:31
905ee4e to
1c3b452
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 12, 2026 23:56
3b4c6bc to
ef554fa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 12, 2026 23:56
1c3b452 to
e715d99
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
3 times, most recently
from
August 13, 2026 06:01
60ed09b to
ee3a910
Compare
The group keeps the needs_offload gate and the allocated filter, and fans out to its cells; each cell talks to its primary (node-0) engine. The cell's arguments are all required, like the engine api it forwards to: a caller that forgets tags means something different from tags=None.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 14, 2026 04:46
78e3233 to
55e7b9b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-3
branch
from
August 14, 2026 04:46
ee3a910 to
30ace97
Compare
guapisolo
approved these changes
Aug 25, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Approving in the context of the #2176 safe-merge checkpoint. This change moves cell-scoped offload/onload/check_weights dispatch into ServerCell while preserving the primary-engine target, allocation filters, fan-out, and result shape. Fresh native and direct review found no actionable issue in this increment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837