Make ServerGroup callers cell-aware and drop the all_engines property - #1865
Open
fzyzcjy wants to merge 1 commit into
Open
Make ServerGroup callers cell-aware and drop the all_engines property#1865fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
July 28, 2026 13:31
5d16f28 to
c321277
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 3, 2026 23:44
183550b to
60cf331
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 3, 2026 23:44
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 3, 2026 23:45
c321277 to
2f3036b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 4, 2026 00:39
60cf331 to
c6343e2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 4, 2026 00:39
2f3036b to
e835dbd
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 4, 2026 06:57
c6343e2 to
26e78ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 4, 2026 06:57
e835dbd to
3dc88c4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 6, 2026 07:03
26e78ff to
faf8e3c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 6, 2026 07:03
3dc88c4 to
ee8c686
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 10, 2026 06:07
faf8e3c to
ea26e46
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 10, 2026 06:07
ee8c686 to
d7451ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 10, 2026 16:07
ea26e46 to
644e904
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 10, 2026 16:07
d7451ff to
3b4b538
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 10, 2026 16:34
644e904 to
c271f13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
2 times, most recently
from
August 12, 2026 02:48
9c16b82 to
905ee4e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 12, 2026 14:31
35e6dfc to
71bbfc9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
2 times, most recently
from
August 12, 2026 23:56
1c3b452 to
e715d99
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 13, 2026 01:13
6680bcb to
4be84ac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 13, 2026 01:13
e715d99 to
09a4e1a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 13, 2026 03:25
4be84ac to
55adc4d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
2 times, most recently
from
August 13, 2026 06:01
086b00e to
78e3233
Compare
Call sites that genuinely need the flat engine-index view (start_engines, stop_engines, recover, mark_alive, _primary_engines_of and the tests built on them) now flatten explicitly via flatten_cells(); the rest iterate cells directly.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 14, 2026 04:46
1a80bba to
b0bd0ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-2
branch
from
August 14, 2026 04:46
78e3233 to
55e7b9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837