Introduce ServerCell and store the group's engines as cells - #1864
Open
fzyzcjy wants to merge 1 commit into
Open
Introduce ServerCell and store the group's engines as cells#1864fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
July 28, 2026 13:31
2807480 to
183550b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
July 28, 2026 13:31
4facd65 to
0ab2036
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 3, 2026 23:44
183550b to
60cf331
Compare
fzyzcjy
requested review from
Shi-Dong,
Ying1123,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 3, 2026 23:44
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 3, 2026 23:45
0ab2036 to
26d154f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 4, 2026 00:39
60cf331 to
c6343e2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 4, 2026 00:39
26d154f to
1a06900
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 4, 2026 06:57
c6343e2 to
26e78ff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 4, 2026 06:57
1a06900 to
5826c45
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
2 times, most recently
from
August 10, 2026 06:07
faf8e3c to
ea26e46
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 10, 2026 06:07
554a993 to
f95c630
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 10, 2026 16:07
ea26e46 to
644e904
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 10, 2026 16:07
f95c630 to
51ff510
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 10, 2026 16:34
644e904 to
c271f13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 12, 2026 02:48
6a9809b to
d147df9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
2 times, most recently
from
August 12, 2026 14:31
35e6dfc to
71bbfc9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
2 times, most recently
from
August 12, 2026 23:56
6bc552c to
bb709ac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
2 times, most recently
from
August 13, 2026 01:13
6680bcb to
4be84ac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 13, 2026 03:25
2accb42 to
91bc342
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 13, 2026 03:25
4be84ac to
55adc4d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-19
branch
from
August 13, 2026 06:01
91bc342 to
2f07e17
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 13, 2026 06:01
55adc4d to
1a80bba
Compare
ServerGroup.all_engines becomes a property flattening the new cells field, so all readers stay unchanged. The one production construction site builds its cells directly, grouping nodes_per_engine engines into each; the tests that build groups from a flat engine list share a helper in their conftest.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-1
branch
from
August 14, 2026 04:46
1a80bba to
b0bd0ff
Compare
guapisolo
approved these changes
Aug 24, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Approving this PR in the context of the #2176 safe-merge checkpoint. Introducing ServerCell is the right ownership model, but the original floor-division grouping could silently drop a trailing engine wrapper for an uneven multi-node topology. #1879 adds the required divisibility fail-fast and focused coverage before #2176, and that fix remains present through the checked chain tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837