Directly call SGLang engines instead of via ray actors in trainers and remove SGLangEngine shells - #1861
Open
fzyzcjy wants to merge 1 commit into
Open
Directly call SGLang engines instead of via ray actors in trainers and remove SGLangEngine shells#1861fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
July 28, 2026 12:56
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 3, 2026 23:44
717cf48 to
33003ed
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
2 times, most recently
from
August 4, 2026 00:39
28437a3 to
51e1316
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
2 times, most recently
from
August 4, 2026 06:57
411ecf3 to
c4f937d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
2 times, most recently
from
August 6, 2026 07:03
5c849ef to
cefbc28
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 10, 2026 06:06
c4f937d to
5e0612a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
2 times, most recently
from
August 10, 2026 16:07
30e603f to
282b8b1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 10, 2026 16:34
048f68b to
fe7eb04
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
from
August 10, 2026 16:34
282b8b1 to
7db556d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 12, 2026 02:48
fe7eb04 to
b731661
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
2 times, most recently
from
August 12, 2026 14:31
73ad0f9 to
7bec756
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
2 times, most recently
from
August 12, 2026 23:56
0c54b25 to
ad934dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
from
August 12, 2026 23:56
7bec756 to
7e64fa5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
from
August 13, 2026 01:13
7e64fa5 to
5e720db
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
from
August 13, 2026 06:01
5e720db to
7b79e2d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 13, 2026 06:01
ad934dc to
6f3ba41
Compare
…d remove SGLangEngine shells Squashed from: - Talk to the engines over HTTP from the trainer too, and drop the engine shells - Fix the trainer-side HTTP conversion found by auditing op3-3 - Release the rollout lock on failure, and cover the orderings that were only implicit
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-3
branch
from
August 14, 2026 04:45
7b79e2d to
c3d799a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-17
branch
from
August 14, 2026 04:45
6f3ba41 to
bcb6d4a
Compare
guapisolo
reviewed
Aug 24, 2026
| async_utils.wait_futures( | ||
| [async_utils.submit(client.pause_generation()) for client in self.rollout_engines] | ||
| ) | ||
| async_utils.wait_futures([async_utils.submit(client.flush_cache()) for client in self.rollout_engines]) |
Collaborator
There was a problem hiding this comment.
[non-blocking] potential perf issue? My codex said.
original cost = max_i(pause_i + flush_i)
new cost = max_i(pause_i) + max_i(flush_i)
Seems trivial. non-blocking
guapisolo
approved these changes
Aug 24, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Approving this PR for the #2176 safe-merge checkpoint. It completes the trainer-side migration from Ray actor API shells to direct SGLangApiClient calls while keeping engine process lifecycle ownership and synchronization explicit. I left a non-blocking performance question about the stronger fleet-wide pause/flush barrier, but no blocking finding remains through the checked chain tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837