Add the sync-to-async bridge for fire-then-rendezvous call sites - #1855
Open
fzyzcjy wants to merge 1 commit into
Open
Add the sync-to-async bridge for fire-then-rendezvous call sites#1855fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
July 28, 2026 12:56
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 3, 2026 23:44
d562b1e to
a34bbc3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 3, 2026 23:44
1c21446 to
60bb61f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 4, 2026 00:39
a34bbc3 to
89cfb93
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 4, 2026 06:56
2eb2e1b to
cd4c421
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 4, 2026 06:56
89cfb93 to
839790f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 10, 2026 06:06
cd4c421 to
de62d6c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 10, 2026 06:06
839790f to
f81e650
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 10, 2026 16:07
de62d6c to
f9e3ec9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 10, 2026 16:07
f81e650 to
b235bfb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 10, 2026 16:34
f9e3ec9 to
ce44b07
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
2 times, most recently
from
August 12, 2026 02:48
9698dc9 to
7a52c65
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 12, 2026 14:31
6a5194c to
c407f31
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 12, 2026 14:31
7a52c65 to
9fd9ece
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-10
branch
from
August 12, 2026 23:56
c407f31 to
9340358
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
2 times, most recently
from
August 13, 2026 06:01
8b7379f to
dd79ed4
Compare
Three engine endpoints — init_weights_update_group, update_weights_from_distributed and load_lora_adapter_from_distributed — block server-side until the NCCL collective forms, and the other party to that collective is the caller itself. The caller must therefore have every request on the wire before it blocks. Ray's `.remote()` gave that for free; an HTTP client has to rebuild it. `AsyncLoopThread.submit` returns a `concurrent.futures.Future` instead of blocking, so synchronous trainer code keeps its fire → collective → collect shape. A background loop rather than a thread pool: a pool with fewer workers than engines queues the last requests behind the collective that is waiting for them. `wait_futures` is the collection point. It takes ray ObjectRefs and futures alike so a call site can migrate its fan-out without changing shape, and it settles every future before raising, since abandoning the rest would leave requests running against engines the caller believes it is done with.
fzyzcjy
force-pushed
the
tom/refactor-miles/op3-11
branch
from
August 14, 2026 04:46
dd79ed4 to
7666abc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837