test: add offload_train_target to the actor-factory args stub - #1834
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
The test arrived in #1469 with a SimpleNamespace args stub that lacks offload_train_target, which the megatron offload path of allocate_gpus_for_actor has read since #1575 — so the test fails with AttributeError on any branch cut from current main. Set the attribute to the CLI default (cpu), matching the TMS_INIT_ENABLE_CPU_BACKUP=1 assertion the test already makes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nblintao
force-pushed
the
tao/fix-actor-factory-test-offload-target
branch
from
July 28, 2026 05:17
289a97c to
1536c21
Compare
Zhichenzzz
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_megatron_offload_uses_torch_memory_saver_preload_resolverfails on any branch cut from current main:The test arrived in #1469 with a
SimpleNamespaceargs stub that lacksoffload_train_target, which the megatron offload path ofallocate_gpus_for_actorhas read since #1575. Post-merge main does not run the test matrix, so this only surfaces on new PRs (first seen on #1833, a docs-only change).One-line fix: set
offload_train_target="cpu"(the CLI default), which matches theTMS_INIT_ENABLE_CPU_BACKUP == "1"assertion the test already makes.🤖 Generated with Claude Code