docs: fix factual errors in fully-async example page - #1809
Closed
Shi-Dong wants to merge 2 commits into
Closed
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes factual errors in
docs/examples/fully-async.mdfound during a fact-check of every page underdocs/examples/against the actual code inexamples/fully_async/.[trainer] iter 1/3000 ...log block. Replaced with the real stdout prints fromfully_async_rollout.py(Creating new global async worker...,Starting async rollout generation for N groups,Rollout completed in ...s! Global worker queue size: N).concurrency=args.sglang_server_concurrencykwarg;AsyncRolloutWorker.__init__only takes(args, data_buffer)._producercoroutine. Replaced with a condensed version of the realcontinuous_worker_loop(reap finished tasks, top up in-flight groups viagenerate_and_rm_group, done-callback onto the output queue), including the real in-flight cap:--rollout-batch-sizegroups, or--async-max-concurrent-samples ÷ n_samples_per_promptwhen set.generate_rollout_fully_async(args, rollout_id, data_buffer, evaluation=False)is synchronous, rejects evaluation mode, drains--rollout-batch-sizegroups, recycles aborted groups, and sorts by prompt index.async/*wandb metrics that the example never logs. Replaced with the real stdout signals plus the standardperf/rollout_timevsperf/actor_train_timecomparison.tp=4 ep=8, a nonexistent--sglang-enable-ep-moeflag, and a batch-size recommendation not in the script.run_qwen3_30b_a3b_fully_async.pyactually uses TP 8 / EP 8, one 8-GPU SGLang engine,--use-tis, and demonstrates the--pause-generation-mode×--update-weight-transfer-modecombinations — every pairing exceptin_place+p2p, which the script rejects.reset_for_retry()first, so they regenerate from the prompt; true resume-from-partial is the stock--partial-rolloutbehavior of the built-in rollout function, which this custom drain loop bypasses. The section now states exactly that.Test plan
examples/fully_async/fully_async_rollout.pyandrun_qwen3_30b_a3b_fully_async.pyon current main