Repository navigation
ci(docker): PR-side image build and run the GPU matrix inside the freshly built image #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c44a3e9
docker: locate the TE install dir without importing it
Zhichenzzz 9454846
ci: build the Docker image on PRs that touch it, without pushing
Zhichenzzz 377ff25
ci: run a GPU test suite inside the freshly built PR image
Zhichenzzz b140481
ci: delete the pr-scoped image tag once its test run passes
Zhichenzzz f638ed3
ci: drop comments from docker-build-pr workflow
Zhichenzzz 610c88e
ci: limit GITHUB_TOKEN to contents:read in docker-build-pr
Zhichenzzz 9ad8629
docs(ci): document the PR-side docker build check
Zhichenzzz a63ad6b
ci: gate the PR test matrix on a fresh image build for docker PRs
Zhichenzzz d214f8a
ci: keep CPU-only stages off the docker-build critical path
Zhichenzzz 768b523
Revert CPU-stage decoupling: the workflow-scope seam test pins both r…
Zhichenzzz 5f3fd2a
Adapt NVFP4QuantizerRef import to TE 2.17 module rename
Zhichenzzz 08dfba1
Use the TE 2.17 quantization_ref_nvfp4 import directly
Zhichenzzz 6bc79c4
Merge main (nvfp4 quantizer refactored past the TE module import)
Zhichenzzz ba27731
ci: exclude docker/Dockerfile.rocm from the PR docker-build trigger
guapisolo 77494e1
docs(ci): fresh PR build outranks the ci-image-tag body directive
guapisolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: Docker Build (PR check) | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'docker/Dockerfile' | ||
| - 'docker/build.py' | ||
| - 'docker/patch/**' | ||
| - 'requirements.txt' | ||
| - '.github/workflows/docker-build-pr.yml' | ||
|
|
||
| concurrency: | ||
| group: docker-build-pr-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-only: | ||
| runs-on: ["h200", "2gpu"] | ||
| timeout-minutes: 180 | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| with: | ||
| driver-opts: | | ||
| image=moby/buildkit:latest | ||
| network=host | ||
|
|
||
| - name: Install Python + dependencies | ||
| run: | | ||
| apt-get update && apt-get install -y python3 python3-pip | ||
| pip3 install --break-system-packages typer | ||
|
|
||
| - name: Login to Docker Hub | ||
| # Fork PRs have no secrets: build without pushing, skip the test stage. | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
|
|
||
| - name: Build (and push a PR-scoped tag for the test stage) | ||
| run: | | ||
| if [ "${{ github.event.pull_request.head.repo.full_name }}" = "${{ github.repository }}" ]; then | ||
| python3 docker/build.py --variant cu13-x86 --image-tag custom \ | ||
| --custom-tag pr-${{ github.event.pull_request.number }} --push | ||
| else | ||
| python3 docker/build.py --variant cu13-x86 --image-tag dev | ||
| fi | ||
|
|
||
| # Smoke the freshly built image with a real GPU suite so a Dockerfile change | ||
| # is validated by tests, not only by "the build finished". | ||
| test-in-fresh-image: | ||
| needs: [build-only] | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: ./.github/workflows/_run-ci.yml | ||
| with: | ||
| container_image: radixark/miles:pr-${{ github.event.pull_request.number }} | ||
| runs_on: '["h200", "2gpu"]' | ||
| execute_command: >- | ||
| python tests/ci/run_suite.py --hw h200 --suite stage-b-2-gpu-h200 | ||
| --cadence pr --labels '' | ||
| secrets: inherit | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.