docker: fix main image build — install TransformerEngine from PyPI, drop stale wheel path - #1789
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
The wheels release still ships transformer_engine_torch 2.12.0; installing it after the 2.17.0 bump (#1781) downgrades transformer-engine-cu13 via its dependency pin and the TE import sanity check fails the build. TE now comes from PyPI, so remove the wheel branch (and delete the stale wheel from /tmp/wheels so nothing else can pick it up).
Zhichenzzz
force-pushed
the
zhichen/te-wheel-version-gate
branch
from
July 24, 2026 19:16
fed9995 to
98d15d6
Compare
yueming-yuan
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-and-pushonmainhas been failing since the TE 2.17.0 bump (#1781):Root cause: the wheels release (
miles-wheels/cu130-x86_64) still shipstransformer_engine_torch-2.12.0, and the TE install block prefers any local wheel it finds. So the build first installstransformer_engine==2.17.0+transformer_engine_cu13==2.17.0from PyPI, then installs the stale 2.12.0 torch wheel — whose dependency pin silently downgradestransformer-engine-cu13back to 2.12.0. The TE patch step'simport transformer_enginethen trips the package sanity check and the image build dies.Change
TE is meant to come from PyPI now (per discussion with @yueming-yuan), so:
pip install --no-build-isolation transformer_engine_torch==2.17.0(the previous fallback path becomes the only path).rm -f /tmp/wheels/transformer_engine*.whlfirst, so the stale wheels can't be picked up by anything downstream.Verification
build-and-pushon this PR exercises the changed path directly (the source build oftransformer_engine_torchadds some build time; that cost only exists until a wheel for the pinned version exists upstream).