chore(docker): upgrade torch_memory_saver to 6d5bce48 - #1773
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Install torch_memory_saver from the default branch instead of pinning a specific commit in the CUDA and ROCm Dockerfiles.
Zhichenzzz
added a commit
that referenced
this pull request
Jul 23, 2026
Unpinning torch_memory_saver (#1773) crossed the multi-cuda-wheel change, whose setup.py now aborts a CUDA source build unless TMS_CUDA_MAJOR is set, breaking the Docker Build. Derive it from the image's torch so cu12 and cu13 variants both work.
Zhichenzzz
added a commit
that referenced
this pull request
Jul 23, 2026
Unpinning torch_memory_saver (#1773) crossed the multi-cuda-wheel change, whose setup.py now aborts a CUDA source build unless TMS_CUDA_MAJOR is set, breaking the Docker Build. Derive it from the image's torch so cu12 and cu13 variants both work.
Collaborator
|
quick question: given fzyzcjy/torch_memory_saver#80 etc may be merged, it would be great to pin tms in dockerfile to ensure reproducibility (and we may even add a quick claude rule) |
Contributor
Author
Sounds good. I was to pin the version but @guapisolo asked me to unpin to use the latest :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the pinned torch_memory_saver commit from d64a639 to 6d5bce48c898c64497be2022fbdc08cc7ddb5637 in both the CUDA and ROCm Dockerfiles.