Add temporary CI-image Dockerfile variant with sglang PR 30499 - #1601
yushengsu-thu wants to merge 1 commit into
Conversation
Builds sglang from pull/30499/head (GDN in_proj_ba LoRA support) so the Qwen3.5 LoRA CI in #1597 can run before the sglang PR merges. Throwaway branch; delete after sglang-miles picks up the PR. Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Dockerfile (docker/Dockerfile.qwen35-gdn) to build a specialized CI image containing various machine learning dependencies, including SGLang, Megatron-LM, and FlashQLA. The review feedback suggests improving the robustness of the GitHub API asset-fetching script by explicitly handling API rate limit errors instead of failing silently when the 'assets' key is missing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | python3 -c "import sys,json,subprocess,os; w='/tmp/wheels'; \ | ||
| [subprocess.run(['curl','-fSL','-o',os.path.join(w,a['name']),a['browser_download_url']],check=True) \ | ||
| for a in json.load(sys.stdin).get('assets',[]) \ | ||
| if a['name'].endswith(('.whl', '.tar.gz')) and not os.path.exists(os.path.join(w,a['name']))]" && \ |
There was a problem hiding this comment.
When fetching the wheels release from the GitHub API, if the API rate limit is exceeded (which is common in CI environments using shared IPs), GitHub returns a 403 Forbidden response with a JSON body containing a message field but no assets field.
Currently, json.load(sys.stdin).get('assets', []) will silently return an empty list [] on rate limit errors, causing the build to succeed in this step but fail later with a cryptic pip install error due to missing wheels.
We can make this more robust by checking for the presence of the assets key and exiting with a clear error message if it is missing.
| python3 -c "import sys,json,subprocess,os; w='/tmp/wheels'; d=json.load(sys.stdin); \
sys.exit('GitHub API Error: ' + str(d.get('message', d))) if 'assets' not in d else \
[subprocess.run(['curl','-fSL','-o',os.path.join(w,a['name']),a['browser_download_url']],check=True) \
for a in d['assets'] \
if a['name'].endswith(('.whl', '.tar.gz')) and not os.path.exists(os.path.join(w,a['name']))]" && \
|
Not for merging — this branch only exists as the build source for the temporary CI image |
Builds sglang from pull/30499/head (GDN in_proj_ba LoRA support) so the Qwen3.5 LoRA CI in #1597 can run before the sglang PR merges. Throwaway branch; delete after sglang-miles picks up the PR.