[weight checker] enable in all CIs + ULP-based quant error tolerance - #1336
Conversation
…-based --check-weight-update-allow-quant-error
There was a problem hiding this comment.
Code Review
This pull request introduces a new command-line argument --check-weight-update-allow-quant-error to allow quantized tensors to differ slightly when comparing weights after an update. This parameter is propagated through the rollout manager, rollout server, server group, and SGLang engine. Additionally, the --check-weight-update-equal flag is now automatically enabled when --ci-test is active, and various end-to-end tests have been updated to utilize the new quantization error tolerance argument. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…d-trip (exclude debug modes)
… mismatch in mixed offload)
…ght-check-ulp # Conflicts: # tests/e2e/megatron/test_deepseek_v32_5layer_fp8.py
ci-sglang-pr: #28082
Replaces #812. sglang-side PR: sgl-project/sglang#28082. Stacked on #1329.
Summary
--check-weight-update-equalwhenever--ci-testis set, so every future CI verifies weight sync between the training actor and SGLang engines after weight update. The now-redundant explicit flags intest_qwen3_4B_p2p.pyandtest_qwen3_30B_A3B/_common.pyare removed.--check-weight-update-allow-quant-error, plumbed throughtrain.py/train_async.py→ rollout manager/server/group → engine → sglang/weights_checker.MILES_TEST_USE_FP8_ROLLOUT, dsv32 fp8 + mxfp8, dsv4-flash (FP8 checkpoint). bf16 checkpoints keep exact-equality comparison.Test plan
run-ci-megatronwith weight checking enabled everywhere🤖 Generated with Claude Code