Support Qwen3 dense 8B and 32B true-on-policy - #1244
Open
maocheng23 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the Qwen3-8B and Qwen3-32B models. It introduces a Qwen3DenseLaunchDefaults dataclass and a lookup dictionary to manage model-specific launch configurations, such as tensor model parallel size, context parallel size, max tokens per GPU, and CPU offload options. Additionally, it updates the launch script arguments and execution logic to utilize these defaults when not explicitly provided, and adds corresponding unit tests to verify the new configurations. There are no review comments, so I have no feedback to provide.
maocheng23
force-pushed
the
support-qwen3-dense-8b-32b
branch
from
May 30, 2026 21:55
a6c8165 to
06442f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing