fix: handle Qwen3.5 in quantize_params_fp8 - #1093
Merged
Zhichenzzz merged 2 commits intoMay 8, 2026
Merged
Conversation
lawrence-harmonic
requested review from
Zhichenzzz,
fzyzcjy,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
May 8, 2026 07:48
Contributor
Author
|
Copying from THUDM/slime#1683 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the FP8 quantization processor to include linear attention parameters and improves the configuration handling for the quantization format. Feedback suggests replacing the use of assert with explicit ValueError exceptions for better production robustness and optimizing the parameter lookup process by moving the list of target weights to a module-level set.
Contributor
|
LGTM! Thanks @lawrence-harmonic ! |
Zhichenzzz
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.