Repository navigation
fix(rollout/session): reseed instead of erroring when no assistant persisted #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidBellamy
wants to merge
1
commit into
radixark:main
Choose a base branch
from
LLM360:fix/rollback-reseed-empty-assistant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic in this new branch appears to be unreachable from
prepare_pretokenizedgiven the current implementation:prepare_pretokenized(line 76), the function returnsNoneifself.token_idsis empty. Sinceself.token_idsis derived fromself.trajectory_token_ids, andself.num_assistantis kept in sync with the length ofself.trajectory_token_ids(seeupdate_pretokenized_stateat line 145),num_assistant == 0impliestoken_idsis empty. Thus,prepare_pretokenizedwould have already returnedNonebefore calling this method._try_detect_and_rollback_to_assistant_checkpointreturns early at line 213 ifself.trajectory_token_idsis empty (which is the case whennum_assistant == 0).If the intention is to handle reseeding when a divergence occurs before the first assistant turn is persisted, the check at line 76 in
prepare_pretokenized(and line 212 here) might need to be adjusted. Additionally, when implementing logic to reset or rollback session state, ensure all generated outputs and metadata fields are cleared to their default state to prevent carrying over stale data from previous attempts.References