Enable accuracy checks in CI & change fsdp_distributed test to non-colocate async - #10
Merged
Conversation
fzyzcjy
changed the title
fzyzcjy
added a commit
that referenced
this pull request
Mar 1, 2026
- #1: Move argparse import to top-level in parallel_utils.py - #2: resolve_megatron_path returns Path instead of str - #3: Log non-zero comparator exit code in compare.py - #4: Use `is not None` instead of truthiness for consistency in compare.py - #5: Replace dataclasses.asdict with explicit kwargs, remove type: ignore - #6: Add PreTrainedTokenizerBase type annotation in prompt_utils.py - #7: Replace assert with ValueError in _resolve_raw_text - #8: Handle default_factory in DataclassArgparseBridge - #9: Document bool | None as unsupported in argparse_utils docstring - #10-#12: Add missing type annotations (model_provider, forward_backward_func, losses, records)
fzyzcjy
added a commit
that referenced
this pull request
Mar 19, 2026
yueming-yuan
pushed a commit
that referenced
this pull request
Mar 31, 2026
Allocate engine_info_bootstrap_port per engine to avoid port conflicts
GuanxingLu
pushed a commit
to GuanxingLu/miles
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.