Skip to content

fix(gdn): only reject THD packed_seq_params, allow BSHD #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhichenzzz merged 1 commit into from
Jun 19, 2026
Merged

fix(gdn): only reject THD packed_seq_params, allow BSHD #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions megatron/core/ssm/gated_delta_net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,10 @@ def forward(
# TODO: support inference
raise NotImplementedError("GDN does not support inference for now.")

if packed_seq_params is not None:
# TODO: support packed sequence
raise NotImplementedError("GDN does not support packed sequence for now.")
if packed_seq_params is not None and packed_seq_params.qkv_format == "thd":
# GDN ignores the bshd PackedSeqParams Megatron passes uniformly; only genuine
# THD packing is unsupported (TODO: port THD support from upstream PR #2645).
raise NotImplementedError("GDN does not support THD packed sequence for now.")

# Input projection
nvtx_range_push(suffix="in_proj")
Expand Down