[3/8] feat: add post-attention and post-MLP layernorm support - #4
Merged
Conversation
yueming-yuan
commented
Feb 18, 2026
yueming-yuan
commented
- Add optional LayerNorm after self-attention and MLP outputs (Qwen3-style)
- New config fields: post_self_attn_layernorm, post_mlp_layernorm
- New CLI args: --post-self-attn-layernorm, --post-mlp-layernorm, --use-gated-attention
- Wired through gpt_layer_specs and transformer_layer forward pass
Add optional LayerNorm after self-attention and MLP outputs, needed for architectures like Qwen3. Controlled via --post-self-attn-layernorm and --post-mlp-layernorm CLI flags. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yueming-yuan
changed the title
guapisolo
pushed a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Yueming Yuan <yym022502@gmail.com>
guapisolo
pushed a commit
that referenced
this pull request
Mar 2, 2026
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Yueming Yuan <yym022502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.